Skip to content

fix(remote-config): js interop types #17806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 3, 2025
+7 −26
Merged

fix(remote-config): js interop types #17806

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
589f144
fix(remote-config): js interop types
MichaelVerdon Oct 22, 2025
95f75ea
fix: more js interop types
MichaelVerdon Oct 27, 2025
e6c6cd2
fix: invalid interop type
MichaelVerdon Oct 27, 2025
8639e9b
fix: getValue to dart
MichaelVerdon Oct 27, 2025
b500a09
fix: lint
MichaelVerdon Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...base_remote_config/firebase_remote_config_web/lib/src/interop/firebase_remote_config.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class RemoteConfig
/// Returns all config values.
Map<String, RemoteConfigValue> getAll() {
// Return type is Map<Object?, Object?>
final map = remote_config_interop.getAll(jsObject).dartify()!
final map = remote_config_interop.getAll(jsObject)
as Map<Object?, Object?>;
// Cast the map to <String, Object?> to mirror expected return type: Record<string, Value>;
final castMap = map.cast<String, Object?>();
Expand All @@ -120,10 +120,10 @@ class RemoteConfig

RemoteConfigValue getValue(String key) => RemoteConfigValue(
utf8.encode(
remote_config_interop.getValue(jsObject, key.toJS).asString().toDart,
remote_config_interop.getValue(jsObject, key.toJS).asString(),
),
getSource(
remote_config_interop.getValue(jsObject, key.toJS).getSource().toDart,
remote_config_interop.getValue(jsObject, key.toJS).asString(),
),
);

Expand Down
5 changes: 3 additions & 2 deletions ...ote_config/firebase_remote_config_web/lib/src/interop/firebase_remote_config_interop.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ library;
import 'dart:js_interop';

import 'package:firebase_core_web/firebase_core_web_interop.dart';
import 'package:firebase_remote_config_platform_interface/firebase_remote_config_platform_interface.dart';

@JS()
@staticInterop
Expand All @@ -33,7 +34,7 @@ external JSPromise fetchConfig(RemoteConfigJsImpl remoteConfig);

@JS()
@staticInterop
external JSAny getAll(RemoteConfigJsImpl remoteConfig);
external Map<String, RemoteConfigValue> getAll(RemoteConfigJsImpl remoteConfig);

@JS()
@staticInterop
Expand All @@ -49,7 +50,7 @@ external JSString getString(RemoteConfigJsImpl remoteConfig, JSString key);

@JS()
@staticInterop
external ValueJsImpl getValue(RemoteConfigJsImpl remoteConfig, JSString key);
external RemoteConfigValue getValue(RemoteConfigJsImpl remoteConfig, JSString key);

@JS()
@staticInterop
Expand Down
Loading