Cleaning up logging in dataconnect:sql:setup #8380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammam-g
requested changes
Mar 28, 2025
src/gcp/cloudsql/permissionsSetup.ts
Outdated
| @@ -343,21 +340,23 @@ export async function setupBrownfieldAsGreenfield( | |||
| const schema = schemaInfo.name; | |||
|
|
|||
| const firebaseOwnerRole = firebaseowner(databaseId, schema); | |||
| const uniqueTablesOwners = filterTableOwners(schemaInfo, databaseId); | |||
| const nonFirebasetablesOwners = [...new Set(schemaInfo.tables.map((t) => t.owner))].filter( | |||
There was a problem hiding this comment.
Not sure if this is intentional or not but this is a regression, I think we should keep filterTableOwners or make sure to be also filter CLOUDSQL_SUPER_USER.
There was a problem hiding this comment.
Definitely, this was just a screwed up merge. Fixing now
| @@ -394,8 +393,8 @@ export async function brownfieldSqlSetup( | |||
| ) { | |||
| const schema = schemaInfo.name; | |||
|
|
|||
| // Step 1: Grant firebasesuperuser access to the original owner. | |||
| const uniqueTablesOwners = filterTableOwners(schemaInfo, databaseId); | |||
tammam-g
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple logging clean ups:
Scenarios Tested