Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set extraEnv in vscode process #8354

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Set extraEnv in vscode process #8354

merged 2 commits into from
Mar 21, 2025

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Mar 21, 2025

Description

Fixes an issue where extraEnv wasn't actually set for code executed as part of the extension.

Also, added some logging to help debug where prod requests are going.

Scenarios Tested

Verified that when I set the DATA_CONNECT_URL env var to staging, Run (production) sends requests to staging.

@joehan joehan requested a review from rosalyntan March 21, 2025 18:26
Copy link
Member

@rosalyntan rosalyntan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@@ -1,4 +1,5 @@
import { dataconnectOrigin } from "../api";
export { dataconnectOrigin } from "../api"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "../api";

@joehan joehan requested a review from hlshen March 21, 2025 19:03
@joehan joehan merged commit 2d3a1fb into master Mar 21, 2025
57 checks passed
@joehan joehan deleted the jh-extra-env-always branch March 21, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants