Update location => primary region in backends table #8205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8205 +/- ##
==========================================
+ Coverage 51.12% 51.17% +0.04%
==========================================
Files 423 423
Lines 29722 29743 +21
Branches 6083 6089 +6
==========================================
+ Hits 15196 15221 +25
+ Misses 13160 13154 -6
- Partials 1366 1368 +2 ☔ View full report in Codecov by Sentry. |
mathu97
approved these changes
Feb 19, 2025
taeold
added a commit
that referenced
this pull request
Mar 24, 2025
* Update "location" => "primary region" in the backend display table. (#8205) * Remove --location from apphosting:backend:list. (#8272) * Remove --location from apphosting:rollouts:create and error when more than one backend is found. (#8271) * Remove --location from apphosting:backends:get and return the first backend if multiple are found. (#8260) * Remove `--location` from apphosting:backends:delete (#8262) * Remove --location from apphosting:backends:create and prompt for primary region. (#8264) * Enable FDC connector evolution and insecure operations linter. (#8281) * Enable FDC connector evolution and insecure operations linter. * Enable in VSCode. * Actually get VSCode working. * Replace pkg with yao-pkg/pkg (#8328) Co-authored-by: aalej <[email protected]> * List regions of duplicate backend in warning/error message (#8285) * Update dataconnect.yaml template to v1. (#8346) * Remove support for node 18 (#8334) --------- Co-authored-by: annajowang <[email protected]> Co-authored-by: Joe Hanley <[email protected]> Co-authored-by: Rosalyn Tan <[email protected]> Co-authored-by: aalej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update "Location" to "Primary Region" when displaying backends in a table.
Scenarios Tested
firebase apphosting:backends:get friendlybugs-codelab
firebase apphosting:backends:list
firebase apphosting:backends:delete friendlybugs-codelab