Skip to content

Fix languageCode parameter in action_code_url #8912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

Fix languageCode parameter in action_code_url #8912

merged 2 commits into from
Apr 16, 2025

Conversation

pashanka
Copy link
Contributor

@pashanka pashanka commented Apr 9, 2025 •
edited
Loading

It was observed that the parameter used for language code in the backend is lang and not languageCode, due to which ActionCode.languageCode will always be null. This is to fix the query parameter, so that the languageCode is populated correctly after parsing.

Issue was originally reported for ios-sdk at firebase/firebase-ios-sdk#14664

Testing

Updated unit tests.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 0d4797a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 9, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (66a09f2)Merge (44b8d2c)Diff
    browser193 kB193 kB-8 B (-0.0%)
    cordova166 kB166 kB-8 B (-0.0%)
    main147 kB147 kB-8 B (-0.0%)
    module193 kB193 kB-8 B (-0.0%)
    react-native165 kB165 kB-8 B (-0.0%)

  • @firebase/auth-cordova

    TypeBase (66a09f2)Merge (44b8d2c)Diff
    browser166 kB166 kB-8 B (-0.0%)
    module166 kB166 kB-8 B (-0.0%)

  • @firebase/auth-web-extension

    TypeBase (66a09f2)Merge (44b8d2c)Diff
    browser142 kB142 kB-8 B (-0.0%)
    main159 kB159 kB-8 B (-0.0%)
    module142 kB142 kB-8 B (-0.0%)

  • @firebase/auth/internal

    TypeBase (66a09f2)Merge (44b8d2c)Diff
    browser204 kB204 kB-8 B (-0.0%)
    main173 kB173 kB-8 B (-0.0%)
    module204 kB204 kB-8 B (-0.0%)

  • @firebase/firestore

    TypeBase (66a09f2)Merge (44b8d2c)Diff
    browser382 kB384 kB+2.45 kB (+0.6%)
    main591 kB594 kB+3.19 kB (+0.5%)
    module382 kB384 kB+2.45 kB (+0.6%)
    react-native382 kB384 kB+2.45 kB (+0.6%)

  • @firebase/firestore-lite

    TypeBase (66a09f2)Merge (44b8d2c)Diff
    browser113 kB114 kB+984 B (+0.9%)
    main155 kB157 kB+1.42 kB (+0.9%)
    module113 kB114 kB+984 B (+0.9%)
    react-native113 kB114 kB+984 B (+0.9%)

  • bundle

    16 size changes

    TypeBase (66a09f2)Merge (44b8d2c)Diff
    auth (EmailAndPassword)87.8 kB87.8 kB-8 B (-0.0%)
    firestore (CSI Auto Indexing Disable and Delete)272 kB274 kB+1.95 kB (+0.7%)
    firestore (CSI Auto Indexing Enable)272 kB274 kB+1.95 kB (+0.7%)
    firestore (Persistence)304 kB306 kB+2.18 kB (+0.7%)
    firestore (Query Cursors)250 kB251 kB+1.31 kB (+0.5%)
    firestore (Query)248 kB249 kB+1.31 kB (+0.5%)
    firestore (Read data once)236 kB237 kB+1.28 kB (+0.5%)
    firestore (Read Write w Persistence)328 kB330 kB+2.24 kB (+0.7%)
    firestore (Realtime updates)238 kB239 kB+1.30 kB (+0.5%)
    firestore (Transaction)215 kB216 kB+1.25 kB (+0.6%)
    firestore (Write data)214 kB216 kB+1.20 kB (+0.6%)
    firestore-lite (Query Cursors)104 kB104 kB+702 B (+0.7%)
    firestore-lite (Query)99.9 kB101 kB+702 B (+0.7%)
    firestore-lite (Read data once)75.4 kB75.9 kB+543 B (+0.7%)
    firestore-lite (Transaction)101 kB101 kB+786 B (+0.8%)
    firestore-lite (Write data)85.0 kB85.5 kB+572 B (+0.7%)

  • firebase

    TypeBase (66a09f2)Merge (44b8d2c)Diff
    firebase-auth-compat.js141 kB141 kB-8 B (-0.0%)
    firebase-auth-cordova.js138 kB138 kB-8 B (-0.0%)
    firebase-auth-web-extension.js120 kB120 kB-8 B (-0.0%)
    firebase-auth.js158 kB158 kB-8 B (-0.0%)
    firebase-compat.js794 kB797 kB+2.42 kB (+0.3%)
    firebase-firestore-compat.js340 kB342 kB+2.43 kB (+0.7%)
    firebase-firestore-lite.js131 kB132 kB+984 B (+0.7%)
    firebase-firestore.js440 kB443 kB+2.45 kB (+0.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2cjPJ7JGGa.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 9, 2025 •
edited
Loading

Size Analysis Report 1

This report is too large (573,236 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/16hwUxJgxe.html

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v10.0

@pashanka pashanka marked this pull request as ready for review April 15, 2025 09:01
yuchenshi
yuchenshi approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for auth

@pashanka pashanka merged commit 1363ecc into main Apr 16, 2025
75 of 94 checks passed
@pashanka pashanka deleted the languageCodeFix branch April 16, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@NhienLam NhienLam NhienLam approved these changes

@mansisampat mansisampat mansisampat approved these changes

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pashanka @google-oss-bot @yuchenshi @NhienLam @mansisampat