[3/4] Integrate realtime ppl into SDK cache management and tests #8910
Conversation
|
Vertex AI Mock Responses Check
|
wu-hui
force-pushed
the
wuandy/RealPpl_2
branch
from
6710057 to
0c570ab
Compare
wu-hui
force-pushed
the
wuandy/RealPpl_3
branch
from
33caa24 to
5065573
Compare
| */ | ||
| export function _onRealtimePipelineSnapshot( | ||
| pipeline: RealtimePipeline, | ||
| options: SnapshotListenOptions, |
There was a problem hiding this comment.
Our design doc was updated to use PipelineListenOptions, which will add serverTimestamps config and remove source. Though, if we want to support source, we can. go/firestore-api-realtime-pipelines
There was a problem hiding this comment.
This can be refactored in a future PR, as long as we track it.
There was a problem hiding this comment.
More generally, we will need to put together a design for how pipeline options are passed to onSnapshot.
| @@ -691,7 +703,7 @@ export function onSnapshot<AppModelType, DbModelType extends DocumentData>( | |||
|
|
|||
| let observer: PartialObserver<ViewSnapshot>; | |||
| let firestore: Firestore; | |||
| let internalQuery: InternalQuery; | |||
| let internalQuery: QueryOrPipeline; | |||
There was a problem hiding this comment.
This type can be reverted back, since we have separated the implementations of listeners for pipelines and query
| export function onPipelineSnapshot< | ||
| AppModelType, | ||
| DbModelType extends DocumentData | ||
| >( |
There was a problem hiding this comment.
We need to drop generics from this new api
| return this.retrieveMatchingLocalDocuments( | ||
| overlays, | ||
| remoteDocuments, | ||
| doc => pipelineMatches(pipeline, doc as MutableDocument) |
There was a problem hiding this comment.
It isn't clear to me, but do we remove offsets and limits from the pipeline argument? If not, could those cause false negatives?
| queryCollectionGroup(query), | ||
| documents | ||
| ); | ||
| // TODO(pipeline): this needs to be adapted to support pipelines as well |
There was a problem hiding this comment.
reminder on this TODO
No description provided.