Skip to content

Fixes for browserCookiePersistence #8893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Apr 2, 2025

FYI @inlined

Copy link

changeset-bot bot commented Apr 2, 2025

⚠️ No Changeset found

Latest commit: 46c9667

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 2, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v8.0

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (88a8055)Merge (f606a99)Diff
    browser193 kB193 kB+112 B (+0.1%)
    cordova166 kB166 kB+61 B (+0.0%)
    main147 kB147 kB+61 B (+0.0%)
    module193 kB193 kB+112 B (+0.1%)
    react-native165 kB165 kB+61 B (+0.0%)
  • @firebase/auth-cordova

    TypeBase (88a8055)Merge (f606a99)Diff
    browser166 kB166 kB+61 B (+0.0%)
    module166 kB166 kB+61 B (+0.0%)
  • @firebase/auth-web-extension

    TypeBase (88a8055)Merge (f606a99)Diff
    browser142 kB142 kB+61 B (+0.0%)
    main159 kB159 kB+61 B (+0.0%)
    module142 kB142 kB+61 B (+0.0%)
  • @firebase/auth/internal

    TypeBase (88a8055)Merge (f606a99)Diff
    browser204 kB204 kB+112 B (+0.1%)
    main173 kB174 kB+61 B (+0.0%)
    module204 kB204 kB+112 B (+0.1%)
  • bundle

    TypeBase (88a8055)Merge (f606a99)Diff
    auth (Anonymous)77.7 kB77.7 kB+58 B (+0.1%)
    auth (EmailAndPassword)87.8 kB87.9 kB+58 B (+0.1%)
    auth (GoogleFBTwitterGitHubPopup)105 kB105 kB+58 B (+0.1%)
    auth (GooglePopup)102 kB102 kB+58 B (+0.1%)
    auth (GoogleRedirect)102 kB102 kB+58 B (+0.1%)
    auth (Phone)95.2 kB95.3 kB+58 B (+0.1%)
  • firebase

    TypeBase (88a8055)Merge (f606a99)Diff
    firebase-auth-compat.js141 kB141 kB+58 B (+0.0%)
    firebase-auth-cordova.js138 kB138 kB+58 B (+0.0%)
    firebase-auth-web-extension.js120 kB120 kB+58 B (+0.0%)
    firebase-auth.js158 kB158 kB+101 B (+0.1%)
    firebase-compat.js794 kB794 kB+58 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/617s1LeM8m.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • ActionCodeOperation

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.5 kB40.6 kB+58 B (+0.1%)
      size-with-ext-deps62.6 kB62.6 kB+58 B (+0.1%)
    • ActionCodeURL

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.4 kB41.4 kB+58 B (+0.1%)
      size-with-ext-deps63.6 kB63.7 kB+58 B (+0.1%)
    • AuthCredential

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.5 kB40.6 kB+58 B (+0.1%)
      size-with-ext-deps62.6 kB62.6 kB+58 B (+0.1%)
    • AuthErrorCodes

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size45.5 kB45.5 kB+58 B (+0.1%)
      size-with-ext-deps67.5 kB67.6 kB+58 B (+0.1%)
    • EmailAuthCredential

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size48.1 kB48.2 kB+58 B (+0.1%)
      size-with-ext-deps70.2 kB70.2 kB+58 B (+0.1%)
    • EmailAuthProvider

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size49.6 kB49.6 kB+58 B (+0.1%)
      size-with-ext-deps71.8 kB71.9 kB+58 B (+0.1%)
    • FacebookAuthProvider

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size45.3 kB45.4 kB+58 B (+0.1%)
      size-with-ext-deps67.4 kB67.4 kB+58 B (+0.1%)
    • FactorId

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.3 kB40.4 kB+58 B (+0.1%)
      size-with-ext-deps62.3 kB62.4 kB+58 B (+0.1%)
    • GithubAuthProvider

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size45.3 kB45.4 kB+58 B (+0.1%)
      size-with-ext-deps67.4 kB67.4 kB+58 B (+0.1%)
    • GoogleAuthProvider

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size45.3 kB45.4 kB+58 B (+0.1%)
      size-with-ext-deps67.4 kB67.4 kB+58 B (+0.1%)
    • OAuthCredential

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size42.4 kB42.5 kB+58 B (+0.1%)
      size-with-ext-deps64.5 kB64.5 kB+58 B (+0.1%)
    • OAuthProvider

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size46.3 kB46.3 kB+58 B (+0.1%)
      size-with-ext-deps68.3 kB68.4 kB+58 B (+0.1%)
    • OperationType

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.4 kB40.4 kB+58 B (+0.1%)
      size-with-ext-deps62.4 kB62.4 kB+58 B (+0.1%)
    • PhoneAuthCredential

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size42.4 kB42.5 kB+58 B (+0.1%)
      size-with-ext-deps64.5 kB64.5 kB+58 B (+0.1%)
    • PhoneAuthProvider

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size51.8 kB51.8 kB+58 B (+0.1%)
      size-with-ext-deps73.8 kB73.9 kB+58 B (+0.1%)
    • PhoneMultiFactorGenerator

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.2 kB41.2 kB+58 B (+0.1%)
      size-with-ext-deps63.2 kB63.2 kB+58 B (+0.1%)
    • ProviderId

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.4 kB40.5 kB+58 B (+0.1%)
      size-with-ext-deps62.4 kB62.5 kB+58 B (+0.1%)
    • RecaptchaVerifier

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size47.3 kB47.3 kB+58 B (+0.1%)
      size-with-ext-deps69.3 kB69.4 kB+58 B (+0.1%)
    • SAMLAuthProvider

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size46.6 kB46.7 kB+58 B (+0.1%)
      size-with-ext-deps68.7 kB68.7 kB+58 B (+0.1%)
    • SignInMethod

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.4 kB40.5 kB+58 B (+0.1%)
      size-with-ext-deps62.5 kB62.5 kB+58 B (+0.1%)
    • TotpMultiFactorGenerator

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size42.8 kB42.9 kB+58 B (+0.1%)
      size-with-ext-deps64.8 kB64.9 kB+58 B (+0.1%)
    • TotpSecret

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.3 kB41.3 kB+58 B (+0.1%)
      size-with-ext-deps63.3 kB63.4 kB+58 B (+0.1%)
    • TwitterAuthProvider

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size45.3 kB45.4 kB+58 B (+0.1%)
      size-with-ext-deps67.4 kB67.4 kB+58 B (+0.1%)
    • applyActionCode

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.4 kB40.5 kB+58 B (+0.1%)
      size-with-ext-deps62.4 kB62.5 kB+58 B (+0.1%)
    • beforeAuthStateChanged

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.4 kB40.4 kB+58 B (+0.1%)
      size-with-ext-deps62.4 kB62.4 kB+58 B (+0.1%)
    • browserCookiePersistence

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size42.2 kB42.3 kB+101 B (+0.2%)
      size-with-ext-deps64.3 kB64.4 kB+101 B (+0.2%)
    • browserLocalPersistence

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size43.3 kB43.4 kB+58 B (+0.1%)
      size-with-ext-deps65.4 kB65.5 kB+58 B (+0.1%)
    • browserPopupRedirectResolver

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size64.9 kB64.9 kB+58 B (+0.1%)
      size-with-ext-deps87.1 kB87.2 kB+58 B (+0.1%)
    • browserSessionPersistence

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size43.3 kB43.4 kB+58 B (+0.1%)
      size-with-ext-deps65.4 kB65.5 kB+58 B (+0.1%)
    • checkActionCode

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.5 kB41.6 kB+58 B (+0.1%)
      size-with-ext-deps63.6 kB63.6 kB+58 B (+0.1%)
    • confirmPasswordReset

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.6 kB40.7 kB+58 B (+0.1%)
      size-with-ext-deps62.7 kB62.7 kB+58 B (+0.1%)
    • connectAuthEmulator

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size42.2 kB42.2 kB+58 B (+0.1%)
      size-with-ext-deps64.6 kB64.6 kB+58 B (+0.1%)
    • createUserWithEmailAndPassword

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size47.3 kB47.3 kB+58 B (+0.1%)
      size-with-ext-deps69.3 kB69.4 kB+58 B (+0.1%)
    • debugErrorMap

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size52.7 kB52.8 kB+58 B (+0.1%)
      size-with-ext-deps74.8 kB74.8 kB+58 B (+0.1%)
    • deleteUser

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.3 kB40.4 kB+58 B (+0.1%)
      size-with-ext-deps62.4 kB62.4 kB+58 B (+0.1%)
    • fetchSignInMethodsForEmail

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.6 kB40.7 kB+58 B (+0.1%)
      size-with-ext-deps62.7 kB62.7 kB+58 B (+0.1%)
    • getAdditionalUserInfo

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.6 kB41.7 kB+58 B (+0.1%)
      size-with-ext-deps63.7 kB63.7 kB+58 B (+0.1%)
    • getAuth

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size75.2 kB75.3 kB+58 B (+0.1%)
      size-with-ext-deps104 kB104 kB+58 B (+0.1%)
    • getIdToken

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.3 kB40.4 kB+58 B (+0.1%)
      size-with-ext-deps62.4 kB62.4 kB+58 B (+0.1%)
    • getIdTokenResult

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.3 kB40.3 kB+58 B (+0.1%)
      size-with-ext-deps62.3 kB62.4 kB+58 B (+0.1%)
    • getMultiFactorResolver

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size43.2 kB43.3 kB+58 B (+0.1%)
      size-with-ext-deps65.2 kB65.3 kB+58 B (+0.1%)
    • getRedirectResult

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size48.0 kB48.0 kB+58 B (+0.1%)
      size-with-ext-deps70.0 kB70.1 kB+58 B (+0.1%)
    • inMemoryPersistence

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.3 kB40.3 kB+58 B (+0.1%)
      size-with-ext-deps62.3 kB62.4 kB+58 B (+0.1%)
    • indexedDBLocalPersistence

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size47.7 kB47.8 kB+58 B (+0.1%)
      size-with-ext-deps69.8 kB69.8 kB+58 B (+0.1%)
    • initializeAuth

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.6 kB40.6 kB+58 B (+0.1%)
      size-with-ext-deps63.1 kB63.1 kB+58 B (+0.1%)
    • initializeRecaptchaConfig

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size44.1 kB44.1 kB+58 B (+0.1%)
      size-with-ext-deps66.1 kB66.1 kB+58 B (+0.1%)
    • isSignInWithEmailLink

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.5 kB41.6 kB+58 B (+0.1%)
      size-with-ext-deps63.8 kB63.8 kB+58 B (+0.1%)
    • linkWithCredential

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.3 kB41.4 kB+58 B (+0.1%)
      size-with-ext-deps63.4 kB63.4 kB+58 B (+0.1%)
    • linkWithPhoneNumber

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size52.5 kB52.6 kB+58 B (+0.1%)
      size-with-ext-deps74.6 kB74.6 kB+58 B (+0.1%)
    • linkWithPopup

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size51.5 kB51.5 kB+58 B (+0.1%)
      size-with-ext-deps73.5 kB73.6 kB+58 B (+0.1%)
    • linkWithRedirect

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size46.6 kB46.7 kB+58 B (+0.1%)
      size-with-ext-deps68.7 kB68.7 kB+58 B (+0.1%)
    • multiFactor

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size42.5 kB42.6 kB+58 B (+0.1%)
      size-with-ext-deps64.5 kB64.6 kB+58 B (+0.1%)
    • onAuthStateChanged

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.3 kB40.4 kB+58 B (+0.1%)
      size-with-ext-deps62.4 kB62.4 kB+58 B (+0.1%)
    • onIdTokenChanged

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.3 kB40.4 kB+58 B (+0.1%)
      size-with-ext-deps62.4 kB62.4 kB+58 B (+0.1%)
    • parseActionCodeURL

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.4 kB41.5 kB+58 B (+0.1%)
      size-with-ext-deps63.7 kB63.7 kB+58 B (+0.1%)
    • prodErrorMap

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.3 kB40.3 kB+58 B (+0.1%)
      size-with-ext-deps62.3 kB62.4 kB+58 B (+0.1%)
    • reauthenticateWithCredential

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.9 kB42.0 kB+58 B (+0.1%)
      size-with-ext-deps64.0 kB64.0 kB+58 B (+0.1%)
    • reauthenticateWithPhoneNumber

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size53.2 kB53.2 kB+58 B (+0.1%)
      size-with-ext-deps75.2 kB75.3 kB+58 B (+0.1%)
    • reauthenticateWithPopup

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size51.6 kB51.7 kB+58 B (+0.1%)
      size-with-ext-deps73.7 kB73.7 kB+58 B (+0.1%)
    • reauthenticateWithRedirect

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size46.4 kB46.5 kB+58 B (+0.1%)
      size-with-ext-deps68.5 kB68.5 kB+58 B (+0.1%)
    • reload

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.3 kB40.3 kB+58 B (+0.1%)
      size-with-ext-deps62.3 kB62.4 kB+58 B (+0.1%)
    • revokeAccessToken

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.3 kB40.4 kB+58 B (+0.1%)
      size-with-ext-deps62.4 kB62.4 kB+58 B (+0.1%)
    • sendEmailVerification

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.3 kB41.4 kB+58 B (+0.1%)
      size-with-ext-deps63.4 kB63.4 kB+58 B (+0.1%)
    • sendPasswordResetEmail

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size47.0 kB47.0 kB+58 B (+0.1%)
      size-with-ext-deps69.0 kB69.0 kB+58 B (+0.1%)
    • sendSignInLinkToEmail

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size47.0 kB47.1 kB+58 B (+0.1%)
      size-with-ext-deps69.1 kB69.1 kB+58 B (+0.1%)
    • setPersistence

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.3 kB40.4 kB+58 B (+0.1%)
      size-with-ext-deps62.4 kB62.4 kB+58 B (+0.1%)
    • signInAnonymously

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.5 kB41.6 kB+58 B (+0.1%)
      size-with-ext-deps63.5 kB63.6 kB+58 B (+0.1%)
    • signInWithCredential

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.7 kB41.8 kB+58 B (+0.1%)
      size-with-ext-deps63.8 kB63.8 kB+58 B (+0.1%)
    • signInWithCustomToken

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.3 kB41.4 kB+58 B (+0.1%)
      size-with-ext-deps63.4 kB63.4 kB+58 B (+0.1%)
    • signInWithEmailAndPassword

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size51.3 kB51.4 kB+58 B (+0.1%)
      size-with-ext-deps73.6 kB73.6 kB+58 B (+0.1%)
    • signInWithEmailLink

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size51.3 kB51.4 kB+58 B (+0.1%)
      size-with-ext-deps73.6 kB73.6 kB+58 B (+0.1%)
    • signInWithPhoneNumber

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size52.9 kB53.0 kB+58 B (+0.1%)
      size-with-ext-deps75.0 kB75.1 kB+58 B (+0.1%)
    • signInWithPopup

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size51.6 kB51.6 kB+58 B (+0.1%)
      size-with-ext-deps73.6 kB73.7 kB+58 B (+0.1%)
    • signInWithRedirect

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size46.1 kB46.2 kB+58 B (+0.1%)
      size-with-ext-deps68.2 kB68.2 kB+58 B (+0.1%)
    • signOut

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.3 kB40.4 kB+58 B (+0.1%)
      size-with-ext-deps62.3 kB62.4 kB+58 B (+0.1%)
    • unlink

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.9 kB40.9 kB+58 B (+0.1%)
      size-with-ext-deps62.9 kB63.0 kB+58 B (+0.1%)
    • updateCurrentUser

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.3 kB40.4 kB+58 B (+0.1%)
      size-with-ext-deps62.4 kB62.4 kB+58 B (+0.1%)
    • updateEmail

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.7 kB40.7 kB+58 B (+0.1%)
      size-with-ext-deps62.7 kB62.8 kB+58 B (+0.1%)
    • updatePassword

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.6 kB40.7 kB+58 B (+0.1%)
      size-with-ext-deps62.6 kB62.7 kB+58 B (+0.1%)
    • updatePhoneNumber

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.1 kB41.2 kB+58 B (+0.1%)
      size-with-ext-deps63.1 kB63.2 kB+58 B (+0.1%)
    • updateProfile

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.8 kB40.9 kB+58 B (+0.1%)
      size-with-ext-deps62.8 kB62.9 kB+58 B (+0.1%)
    • useDeviceLanguage

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.3 kB40.4 kB+58 B (+0.1%)
      size-with-ext-deps62.4 kB62.4 kB+58 B (+0.1%)
    • validatePassword

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size40.4 kB40.4 kB+58 B (+0.1%)
      size-with-ext-deps62.4 kB62.4 kB+58 B (+0.1%)
    • verifyBeforeUpdateEmail

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.4 kB41.4 kB+58 B (+0.1%)
      size-with-ext-deps63.4 kB63.5 kB+58 B (+0.1%)
    • verifyPasswordResetCode

      Size

      TypeBase (88a8055)Merge (f606a99)Diff
      size41.6 kB41.7 kB+58 B (+0.1%)
      size-with-ext-deps63.6 kB63.7 kB+58 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LWit7jHV8r.html

@DellaBitta
Copy link
Contributor

Could you fill out the PR template please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants