Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FDC Parsing Improvements #8892

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

FDC Parsing Improvements #8892

wants to merge 13 commits into from

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented Apr 2, 2025

Fix issue where ipv6 addresses weren't getting parsed correctly when setting FIREBASE_DATA_CONNECT_EMULATOR_HOST

@maneesht maneesht requested review from aashishpatil-g and a team as code owners April 2, 2025 18:51
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c37c5a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/data-connect Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v8.0

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 2, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/data-connect

    TypeBase (88a8055)Merge (1400242)Diff
    browser21.4 kB21.3 kB-59 B (-0.3%)
    main23.6 kB23.6 kB-59 B (-0.2%)
    module21.4 kB21.3 kB-59 B (-0.3%)

  • firebase

    TypeBase (88a8055)Merge (1400242)Diff
    firebase-data-connect.js17.6 kB17.5 kB-66 B (-0.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6laYeQDecT.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 2, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/data-connect

    • CallerSdkTypeEnum

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.5 kB-83 B (-0.7%)
      size-with-ext-deps30.8 kB30.7 kB-84 B (-0.3%)

    • DataConnect

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.5 kB-83 B (-0.7%)
      size-with-ext-deps30.8 kB30.7 kB-84 B (-0.3%)

    • DataConnectError

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.5 kB-83 B (-0.7%)
      size-with-ext-deps30.8 kB30.7 kB-84 B (-0.3%)

    • DataConnectOperationError

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.5 kB-83 B (-0.7%)
      size-with-ext-deps30.8 kB30.7 kB-84 B (-0.3%)

    • MUTATION_STR

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.5 kB-83 B (-0.7%)
      size-with-ext-deps30.8 kB30.7 kB-84 B (-0.3%)

    • MutationManager

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.5 kB-83 B (-0.7%)
      size-with-ext-deps30.8 kB30.7 kB-84 B (-0.3%)

    • QUERY_STR

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.5 kB-83 B (-0.7%)
      size-with-ext-deps30.8 kB30.7 kB-84 B (-0.3%)

    • SOURCE_CACHE

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.5 kB-83 B (-0.7%)
      size-with-ext-deps30.8 kB30.7 kB-84 B (-0.3%)

    • SOURCE_SERVER

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.5 kB-83 B (-0.7%)
      size-with-ext-deps30.8 kB30.7 kB-84 B (-0.3%)

    • areTransportOptionsEqual

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.5 kB-83 B (-0.7%)
      size-with-ext-deps30.8 kB30.7 kB-84 B (-0.3%)

    • connectDataConnectEmulator

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.6 kB-66 B (-0.5%)
      size-with-ext-deps30.9 kB30.8 kB-67 B (-0.2%)

    • executeMutation

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.6 kB-83 B (-0.7%)
      size-with-ext-deps30.9 kB30.8 kB-84 B (-0.3%)

    • executeQuery

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.5 kB-83 B (-0.7%)
      size-with-ext-deps30.9 kB30.8 kB-84 B (-0.3%)

    • getDataConnect

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size13.3 kB13.2 kB-83 B (-0.6%)
      size-with-ext-deps38.6 kB38.5 kB-84 B (-0.2%)

    • mutationRef

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.7 kB12.6 kB-83 B (-0.7%)
      size-with-ext-deps30.9 kB30.8 kB-84 B (-0.3%)

    • parseOptions

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.5 kB-83 B (-0.7%)
      size-with-ext-deps30.8 kB30.7 kB-84 B (-0.3%)

    • queryRef

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.7 kB12.6 kB-83 B (-0.7%)
      size-with-ext-deps30.9 kB30.8 kB-84 B (-0.3%)

    • setLogLevel

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.5 kB-83 B (-0.7%)
      size-with-ext-deps30.8 kB30.8 kB-84 B (-0.3%)

    • subscribe

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size13.8 kB13.7 kB-83 B (-0.6%)
      size-with-ext-deps39.2 kB39.1 kB-84 B (-0.2%)

    • terminate

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.6 kB12.5 kB-83 B (-0.7%)
      size-with-ext-deps30.8 kB30.7 kB-84 B (-0.3%)

    • toQueryRef

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size13.5 kB13.4 kB-83 B (-0.6%)
      size-with-ext-deps38.8 kB38.7 kB-84 B (-0.2%)

    • validateArgs

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size13.4 kB13.3 kB-83 B (-0.6%)
      size-with-ext-deps38.8 kB38.7 kB-84 B (-0.2%)

    • validateDCOptions

      Size

      TypeBase (88a8055)Merge (1400242)Diff
      size12.8 kB12.7 kB-83 B (-0.6%)
      size-with-ext-deps31.0 kB31.0 kB-84 B (-0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UD2nsC0xyh.html

@maneesht maneesht requested review from a team as code owners April 2, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashishpatil-g aashishpatil-g aashishpatil-g left review comments

@yuchenshi yuchenshi yuchenshi approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maneesht @google-oss-bot @yuchenshi @aashishpatil-g