Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VinF Hybrid Inference #2: Introduce ChromeAdapter class #8877

Open
wants to merge 5 commits into
base: erikeldridge-vertex-api
Choose a base branch
from

Conversation

erikeldridge
Copy link

This change minimally introduces a ChromeAdapter class to abstract interactions with Chrome's Prompt API.

To constrain the scope of the change, this only injects the adapter into the generateContent path. If we agree on this approach, a subsequent PR can inject the adapter into the generateContentStream and countTokens paths.

This builds on the API change added by #8874. The diff is against the erikeldridge-vertex-api branch used for that PR. Once we merge that change, we can re-diff this against the integration branch.

@erikeldridge erikeldridge requested a review from a team as a code owner March 27, 2025 23:22
Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: 08d341f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 27, 2025

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (78fed95)Merge (b38556b)Diff
    browser35.0 kB35.8 kB+838 B (+2.4%)
    main36.0 kB36.8 kB+838 B (+2.3%)
    module35.0 kB35.8 kB+838 B (+2.4%)
  • firebase

    TypeBase (78fed95)Merge (b38556b)Diff
    firebase-vertexai.js28.4 kB28.9 kB+493 B (+1.7%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IOVAtqeyo4.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 27, 2025

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • ChatSession

      Size

      TypeBase (78fed95)Merge (b38556b)Diff
      size15.8 kB16.0 kB+175 B (+1.1%)
      size-with-ext-deps34.7 kB34.9 kB+175 B (+0.5%)

      Dependency

      TypeBase (78fed95)Merge (b38556b)Diff
      functions

      21 dependencies

      addHelpers
      aggregateResponses
      assignRoleToPartsAndValidateSendMessageRequest
      constructRequest
      createEnhancedContentResponse
      formatBlockErrorMessage
      formatNewContent
      generateContent
      generateContentStream
      generateResponseSequence
      getClientHeaders
      getFunctionCalls
      getHeaders
      getResponsePromise
      getResponseStream
      getText
      hadBadFinishReason
      makeRequest
      processStream
      registerVertex
      validateChatHistory

      22 dependencies

      addHelpers
      aggregateResponses
      assignRoleToPartsAndValidateSendMessageRequest
      constructRequest
      createEnhancedContentResponse
      formatBlockErrorMessage
      formatNewContent
      generateContent
      generateContentOnCloud
      generateContentStream
      generateResponseSequence
      getClientHeaders
      getFunctionCalls
      getHeaders
      getResponsePromise
      getResponseStream
      getText
      hadBadFinishReason
      makeRequest
      processStream
      registerVertex
      validateChatHistory

      + generateContentOnCloud

    • GenerativeModel

      Size

      TypeBase (78fed95)Merge (b38556b)Diff
      size19.0 kB19.2 kB+236 B (+1.2%)
      size-with-ext-deps37.9 kB38.2 kB+236 B (+0.6%)

      Dependency

      TypeBase (78fed95)Merge (b38556b)Diff
      functions

      24 dependencies

      addHelpers
      aggregateResponses
      assignRoleToPartsAndValidateSendMessageRequest
      constructRequest
      countTokens
      createEnhancedContentResponse
      formatBlockErrorMessage
      formatGenerateContentInput
      formatNewContent
      formatSystemInstruction
      generateContent
      generateContentStream
      generateResponseSequence
      getClientHeaders
      getFunctionCalls
      getHeaders
      getResponsePromise
      getResponseStream
      getText
      hadBadFinishReason
      makeRequest
      processStream
      registerVertex
      validateChatHistory

      25 dependencies

      addHelpers
      aggregateResponses
      assignRoleToPartsAndValidateSendMessageRequest
      constructRequest
      countTokens
      createEnhancedContentResponse
      formatBlockErrorMessage
      formatGenerateContentInput
      formatNewContent
      formatSystemInstruction
      generateContent
      generateContentOnCloud
      generateContentStream
      generateResponseSequence
      getClientHeaders
      getFunctionCalls
      getHeaders
      getResponsePromise
      getResponseStream
      getText
      hadBadFinishReason
      makeRequest
      processStream
      registerVertex
      validateChatHistory

      + generateContentOnCloud

    • ImagenModel

      Size

      TypeBase (78fed95)Merge (b38556b)Diff
      size20.7 kB21.0 kB+236 B (+1.1%)
      size-with-ext-deps39.7 kB39.9 kB+236 B (+0.6%)

      Dependency

      TypeBase (78fed95)Merge (b38556b)Diff
      functions

      26 dependencies

      addHelpers
      aggregateResponses
      assignRoleToPartsAndValidateSendMessageRequest
      constructRequest
      countTokens
      createEnhancedContentResponse
      createPredictRequestBody
      formatBlockErrorMessage
      formatGenerateContentInput
      formatNewContent
      formatSystemInstruction
      generateContent
      generateContentStream
      generateResponseSequence
      getClientHeaders
      getFunctionCalls
      getHeaders
      getResponsePromise
      getResponseStream
      getText
      hadBadFinishReason
      handlePredictResponse
      makeRequest
      processStream
      registerVertex
      validateChatHistory

      27 dependencies

      addHelpers
      aggregateResponses
      assignRoleToPartsAndValidateSendMessageRequest
      constructRequest
      countTokens
      createEnhancedContentResponse
      createPredictRequestBody
      formatBlockErrorMessage
      formatGenerateContentInput
      formatNewContent
      formatSystemInstruction
      generateContent
      generateContentOnCloud
      generateContentStream
      generateResponseSequence
      getClientHeaders
      getFunctionCalls
      getHeaders
      getResponsePromise
      getResponseStream
      getText
      hadBadFinishReason
      handlePredictResponse
      makeRequest
      processStream
      registerVertex
      validateChatHistory

      + generateContentOnCloud

    • VertexAIModel

      Size

      TypeBase (78fed95)Merge (b38556b)Diff
      size19.0 kB19.2 kB+236 B (+1.2%)
      size-with-ext-deps37.9 kB38.2 kB+236 B (+0.6%)

      Dependency

      TypeBase (78fed95)Merge (b38556b)Diff
      functions

      24 dependencies

      addHelpers
      aggregateResponses
      assignRoleToPartsAndValidateSendMessageRequest
      constructRequest
      countTokens
      createEnhancedContentResponse
      formatBlockErrorMessage
      formatGenerateContentInput
      formatNewContent
      formatSystemInstruction
      generateContent
      generateContentStream
      generateResponseSequence
      getClientHeaders
      getFunctionCalls
      getHeaders
      getResponsePromise
      getResponseStream
      getText
      hadBadFinishReason
      makeRequest
      processStream
      registerVertex
      validateChatHistory

      25 dependencies

      addHelpers
      aggregateResponses
      assignRoleToPartsAndValidateSendMessageRequest
      constructRequest
      countTokens
      createEnhancedContentResponse
      formatBlockErrorMessage
      formatGenerateContentInput
      formatNewContent
      formatSystemInstruction
      generateContent
      generateContentOnCloud
      generateContentStream
      generateResponseSequence
      getClientHeaders
      getFunctionCalls
      getHeaders
      getResponsePromise
      getResponseStream
      getText
      hadBadFinishReason
      makeRequest
      processStream
      registerVertex
      validateChatHistory

      + generateContentOnCloud

    • getGenerativeModel

      Size

      TypeBase (78fed95)Merge (b38556b)Diff
      size19.2 kB19.7 kB+474 B (+2.5%)
      size-with-ext-deps38.2 kB38.7 kB+474 B (+1.2%)

      Dependency

      TypeBase (78fed95)Merge (b38556b)Diff
      functions

      25 dependencies

      addHelpers
      aggregateResponses
      assignRoleToPartsAndValidateSendMessageRequest
      constructRequest
      countTokens
      createEnhancedContentResponse
      formatBlockErrorMessage
      formatGenerateContentInput
      formatNewContent
      formatSystemInstruction
      generateContent
      generateContentStream
      generateResponseSequence
      getClientHeaders
      getFunctionCalls
      getGenerativeModel
      getHeaders
      getResponsePromise
      getResponseStream
      getText
      hadBadFinishReason
      makeRequest
      processStream
      registerVertex
      validateChatHistory

      26 dependencies

      addHelpers
      aggregateResponses
      assignRoleToPartsAndValidateSendMessageRequest
      constructRequest
      countTokens
      createEnhancedContentResponse
      formatBlockErrorMessage
      formatGenerateContentInput
      formatNewContent
      formatSystemInstruction
      generateContent
      generateContentOnCloud
      generateContentStream
      generateResponseSequence
      getClientHeaders
      getFunctionCalls
      getGenerativeModel
      getHeaders
      getResponsePromise
      getResponseStream
      getText
      hadBadFinishReason
      makeRequest
      processStream
      registerVertex
      validateChatHistory

      + generateContentOnCloud

      classes

      ChatSession
      GenerativeModel
      RequestUrl
      VertexAIError
      VertexAIModel
      VertexAIService

      ChatSession
      ChromeAdapter
      GenerativeModel
      RequestUrl
      VertexAIError
      VertexAIModel
      VertexAIService

      + ChromeAdapter

    • getImagenModel

      Size

      TypeBase (78fed95)Merge (b38556b)Diff
      size20.9 kB21.1 kB+236 B (+1.1%)
      size-with-ext-deps39.9 kB40.1 kB+236 B (+0.6%)

      Dependency

      TypeBase (78fed95)Merge (b38556b)Diff
      functions

      27 dependencies

      addHelpers
      aggregateResponses
      assignRoleToPartsAndValidateSendMessageRequest
      constructRequest
      countTokens
      createEnhancedContentResponse
      createPredictRequestBody
      formatBlockErrorMessage
      formatGenerateContentInput
      formatNewContent
      formatSystemInstruction
      generateContent
      generateContentStream
      generateResponseSequence
      getClientHeaders
      getFunctionCalls
      getHeaders
      getImagenModel
      getResponsePromise
      getResponseStream
      getText
      hadBadFinishReason
      handlePredictResponse
      makeRequest
      processStream
      registerVertex
      validateChatHistory

      28 dependencies

      addHelpers
      aggregateResponses
      assignRoleToPartsAndValidateSendMessageRequest
      constructRequest
      countTokens
      createEnhancedContentResponse
      createPredictRequestBody
      formatBlockErrorMessage
      formatGenerateContentInput
      formatNewContent
      formatSystemInstruction
      generateContent
      generateContentOnCloud
      generateContentStream
      generateResponseSequence
      getClientHeaders
      getFunctionCalls
      getHeaders
      getImagenModel
      getResponsePromise
      getResponseStream
      getText
      hadBadFinishReason
      handlePredictResponse
      makeRequest
      processStream
      registerVertex
      validateChatHistory

      + generateContentOnCloud

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EL93dL8zqY.html

@erikeldridge erikeldridge requested a review from hsubox76 March 28, 2025 16:29
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants