Discard earliest heartbeat once there are 30 heartbeats #8724
+101
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1df9887 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
DellaBitta
requested changes
Jan 23, 2025
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (212,236 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
DellaBitta
approved these changes
Jan 23, 2025
| expect( | ||
| heartbeatService._heartbeatsCache?.heartbeats.indexOf(earliestHeartbeat) | ||
| ).to.equal(-1); | ||
| }); | ||
| it('triggerHeartbeat() never exceeds 30 heartbeats', async () => { | ||
| it('triggerHeartbeat() never exceeds MAX_NUM_STORED_HEARTBEATS heartbeats', async () => { |
There was a problem hiding this comment.
nit, the second heartbeats in this string seems redundant.
DellaBitta
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we discard heartbeats once they are 30 days old. This PR changes this behaviour to only discard the earliest heartbeat once a limit of 30 heartbeats in IndexedDB has been reached.