SSR related improvements for RC client SDK. #8699

kjelko · 2025-01-09T16:32:25Z

SSR related improvements for RC client SDK.

Exposes an initialFetchResponse arg that pre-hydrates the client SDK state
Adds an argument that allows setting an alternate template ID to fetch from
Splits storage impls into a simple in-memory version that can be run in SSR contexts
Adds some basic tests for the API functions, which were previously untested

…ations

changeset-bot · 2025-01-09T16:32:30Z

🦋 Changeset detected

Latest commit: 221d659

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/remote-config	Minor
firebase	Minor
@firebase/remote-config-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2025-01-09T16:45:04Z

Size Report ¹

Affected Products

@firebase/app
Type Base (645487b) Merge (736c452) Diff
browser 18.4 kB 19.2 kB +846 B (+4.6%)
main 19.3 kB 20.1 kB +838 B (+4.4%)
module 18.4 kB 19.2 kB +846 B (+4.6%)

`@firebase/auth`

Type	Base (`645487b`)	Merge (`736c452`)	Diff
browser	188 kB	188 kB	+107 B (+0.1%)
cordova	164 kB	164 kB	+107 B (+0.1%)
main	145 kB	145 kB	+111 B (+0.1%)
module	188 kB	188 kB	+107 B (+0.1%)
react-native	163 kB	163 kB	+113 B (+0.1%)

@firebase/auth-cordova
Type Base (645487b) Merge (736c452) Diff
browser 164 kB 164 kB +107 B (+0.1%)
module 164 kB 164 kB +107 B (+0.1%)
@firebase/auth-web-extension
Type Base (645487b) Merge (736c452) Diff
browser 140 kB 140 kB +107 B (+0.1%)
main 157 kB 157 kB +113 B (+0.1%)
module 140 kB 140 kB +107 B (+0.1%)
@firebase/auth/internal
Type Base (645487b) Merge (736c452) Diff
browser 199 kB 199 kB +107 B (+0.1%)
main 171 kB 171 kB +113 B (+0.1%)
module 199 kB 199 kB +107 B (+0.1%)
@firebase/data-connect
Type Base (645487b) Merge (736c452) Diff
browser 20.2 kB 20.3 kB +32 B (+0.2%)
main 22.1 kB 22.2 kB +23 B (+0.1%)
module 20.2 kB 20.3 kB +32 B (+0.2%)
@firebase/database
Type Base (645487b) Merge (736c452) Diff
browser 249 kB 249 kB +332 B (+0.1%)
main 254 kB 254 kB +325 B (+0.1%)
module 249 kB 249 kB +332 B (+0.1%)
@firebase/database-compat/standalone
Type Base (645487b) Merge (736c452) Diff
main 340 kB 365 kB +25.9 kB (+7.6%)
@firebase/firestore
Type Base (645487b) Merge (736c452) Diff
browser 382 kB 380 kB -1.67 kB (-0.4%)
main 589 kB 589 kB +270 B (+0.0%)
module 382 kB 380 kB -1.67 kB (-0.4%)
react-native 382 kB 380 kB -1.66 kB (-0.4%)
@firebase/firestore-lite
Type Base (645487b) Merge (736c452) Diff
browser 111 kB 112 kB +222 B (+0.2%)
main 154 kB 154 kB +269 B (+0.2%)
module 111 kB 112 kB +222 B (+0.2%)
react-native 112 kB 112 kB +234 B (+0.2%)
@firebase/functions
Type Base (645487b) Merge (736c452) Diff
browser 13.7 kB 14.0 kB +313 B (+2.3%)
main 14.2 kB 14.6 kB +306 B (+2.1%)
module 13.7 kB 14.0 kB +313 B (+2.3%)
@firebase/performance
Type Base (645487b) Merge (736c452) Diff
browser 29.1 kB 30.6 kB +1.51 kB (+5.2%)
main 29.5 kB 31.1 kB +1.56 kB (+5.3%)
module 29.1 kB 30.6 kB +1.51 kB (+5.2%)
@firebase/remote-config
Type Base (645487b) Merge (736c452) Diff
browser 21.7 kB 23.2 kB +1.51 kB (+7.0%)
main 22.9 kB 24.4 kB +1.51 kB (+6.6%)
module 21.7 kB 23.2 kB +1.51 kB (+7.0%)
@firebase/storage
Type Base (645487b) Merge (736c452) Diff
browser 57.8 kB 58.0 kB +128 B (+0.2%)
main 59.3 kB 59.4 kB +111 B (+0.2%)
module 57.8 kB 58.0 kB +128 B (+0.2%)
@firebase/vertexai
Type Base (645487b) Merge (736c452) Diff
browser 28.8 kB 29.0 kB +220 B (+0.8%)
main 29.6 kB 29.9 kB +203 B (+0.7%)
module 28.8 kB 29.0 kB +220 B (+0.8%)

`bundle`

41 size changes

Type	Base (`645487b`)	Merge (`736c452`)	Diff
auth (Anonymous)	76.2 kB	76.4 kB	+130 B (+0.2%)
auth (EmailAndPassword)	86.4 kB	86.5 kB	+130 B (+0.2%)
auth (GoogleFBTwitterGitHubPopup)	103 kB	103 kB	+130 B (+0.1%)
auth (GooglePopup)	100 kB	100 kB	+130 B (+0.1%)
auth (GoogleRedirect)	100 kB	101 kB	+130 B (+0.1%)
auth (Phone)	93.8 kB	93.9 kB	+130 B (+0.1%)
database (Append to a list of data)	149 kB	149 kB	+372 B (+0.2%)
database (Filtering data)	148 kB	148 kB	+372 B (+0.3%)
database (Listen for child events)	164 kB	165 kB	+372 B (+0.2%)
database (Listen for value events + Detach listeners)	164 kB	165 kB	+372 B (+0.2%)
database (Listen for value events)	164 kB	165 kB	+372 B (+0.2%)
database (Read data once)	164 kB	164 kB	+372 B (+0.2%)
database (Save data as transactions)	166 kB	167 kB	+372 B (+0.2%)
database (Sort data)	150 kB	150 kB	+372 B (+0.2%)
database (Write data)	148 kB	149 kB	+372 B (+0.3%)
firestore (CSI Auto Indexing Disable and Delete)	272 kB	271 kB	-1.32 kB (-0.5%)
firestore (CSI Auto Indexing Enable)	272 kB	271 kB	-1.32 kB (-0.5%)
firestore (Persistence)	304 kB	302 kB	-1.48 kB (-0.5%)
firestore (Query Cursors)	249 kB	249 kB	+98 B (+0.0%)
firestore (Query)	247 kB	247 kB	+98 B (+0.0%)
firestore (Read data once)	235 kB	235 kB	+83 B (+0.0%)
firestore (Read Write w Persistence)	328 kB	327 kB	-1.58 kB (-0.5%)
firestore (Realtime updates)	237 kB	237 kB	+83 B (+0.0%)
firestore (Transaction)	214 kB	214 kB	+157 B (+0.1%)
firestore (Write data)	213 kB	214 kB	+130 B (+0.1%)
firestore-lite (Query Cursors)	103 kB	103 kB	+224 B (+0.2%)
firestore-lite (Query)	98.8 kB	99.1 kB	+242 B (+0.2%)
firestore-lite (Read data once)	74.3 kB	74.5 kB	+223 B (+0.3%)
firestore-lite (Transaction)	99.5 kB	99.8 kB	+243 B (+0.2%)
firestore-lite (Write data)	83.9 kB	84.1 kB	+220 B (+0.3%)
functions (call)	34.4 kB	34.7 kB	+318 B (+0.9%)
performance (trace)	51.8 kB	62.3 kB	+10.5 kB (+20.2%)
remote-config (getAndFetch)	47.5 kB	48.7 kB	+1.13 kB (+2.4%)
storage (getBytes)	42.1 kB	42.3 kB	+175 B (+0.4%)
storage (getDownloadURL)	44.2 kB	44.4 kB	+175 B (+0.4%)
storage (getMetadata)	43.6 kB	43.8 kB	+175 B (+0.4%)
storage (list + listAll)	43.1 kB	43.2 kB	+175 B (+0.4%)
storage (updateMetadata)	43.9 kB	44.1 kB	+175 B (+0.4%)
storage (uploadBytes)	48.8 kB	48.9 kB	+175 B (+0.4%)
storage (uploadBytesResumable)	58.7 kB	58.9 kB	+175 B (+0.3%)
storage (uploadString)	49.0 kB	49.1 kB	+175 B (+0.4%)

`firebase`

28 size changes

Type	Base (`645487b`)	Merge (`736c452`)	Diff
firebase-analytics.js	29.8 kB	29.7 kB	-22 B (-0.1%)
firebase-app-check.js	24.9 kB	24.9 kB	-3 B (-0.0%)
firebase-app-compat.js	31.8 kB	32.3 kB	+552 B (+1.7%)
firebase-app.js	101 kB	102 kB	+1.43 kB (+1.4%)
firebase-auth-compat.js	143 kB	143 kB	+109 B (+0.1%)
firebase-auth-cordova.js	136 kB	136 kB	+76 B (+0.1%)
firebase-auth-web-extension.js	119 kB	119 kB	+59 B (+0.0%)
firebase-auth.js	155 kB	155 kB	-43 B (-0.0%)
firebase-compat.js	798 kB	808 kB	+9.96 kB (+1.2%)
firebase-data-connect.js	16.7 kB	16.8 kB	+1 B (+0.0%)
firebase-database-compat.js	166 kB	166 kB	+305 B (+0.2%)
firebase-database.js	186 kB	187 kB	+250 B (+0.1%)
firebase-firestore-compat.js	347 kB	345 kB	-1.77 kB (-0.5%)
firebase-firestore-lite.js	130 kB	130 kB	+218 B (+0.2%)
firebase-firestore.js	441 kB	439 kB	-1.75 kB (-0.4%)
firebase-functions-compat.js	10.4 kB	10.6 kB	+231 B (+2.2%)
firebase-functions.js	14.6 kB	14.8 kB	+200 B (+1.4%)
firebase-installations.js	15.2 kB	15.2 kB	+8 B (+0.1%)
firebase-messaging-sw.js	30.1 kB	30.1 kB	-29 B (-0.1%)
firebase-messaging.js	29.1 kB	29.1 kB	-34 B (-0.1%)
firebase-performance-compat.js	30.8 kB	40.9 kB	+10.1 kB (+32.7%)
firebase-performance-standalone-compat.js	93.7 kB	105 kB	+11.1 kB (+11.8%)
firebase-performance.js	35.1 kB	45.5 kB	+10.4 kB (+29.6%)
firebase-remote-config-compat.js	28.4 kB	28.8 kB	+435 B (+1.5%)
firebase-remote-config.js	31.3 kB	32.7 kB	+1.40 kB (+4.5%)
firebase-storage-compat.js	40.3 kB	40.4 kB	+109 B (+0.3%)
firebase-storage.js	46.2 kB	46.3 kB	+81 B (+0.2%)
firebase-vertexai.js	23.8 kB	24.0 kB	+163 B (+0.7%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/JHJrCiSIJ9.html

google-oss-bot · 2025-01-09T16:56:30Z

Size Analysis Report ¹

This report is too large (779,027 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/rwMEeG8Aam.html

github-actions · 2025-01-09T19:13:42Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

packages/remote-config/src/api.ts

packages/remote-config/test/api.test.ts

DellaBitta

It seems thatFetchResponse isn't an exported type currently. It lives in src/client/remote_config_fetch_client.ts but it should be moved to src/public_types.ts and that should export it.

packages/remote-config/src/api.ts

packages/remote-config/src/storage/storage.ts

ashish-kothari

LGTM!

jenh

A few interface links are dropping out of the devsite docs, but otherwise LGTM.

packages/remote-config/src/public_types.ts

jenh

(Missed a few things, thanks to @egilmorez for the assist!)

packages/remote-config/src/api.ts

DellaBitta

One more change from my end, then waiting on @jamesdaniels' testing for final merge approval.

DellaBitta · 2025-01-23T19:23:14Z

packages/remote-config/src/api.ts

@@ -41,10 +42,40 @@ import { getModularInstance } from '@firebase/util';
 *


Add a @param here for RemoteConfigOptions

Kevin Elko added 8 commits January 8, 2025 15:26

Add config option for templateId

18d1fd8

Update API to accept initial config as a part of getRemoteConfig options

fce5596

split storage into indexeddeb storage and in-memory storage implement…

da21142

…ations

split out storage impls

11c7252

Initial pass at adding some tests

d1f6bfd

rename and clean up a few things

2bbe42f

clean up after merging main

d145636

Run docgen

2255b79

kjelko requested review from a team and erikeldridge as code owners January 9, 2025 16:32

kjelko requested a review from ashish-kothari January 9, 2025 16:32

run formatter

872be7f

kjelko changed the title ~~Kjelko/rc js~~ SSR related improvements for RC client SDK. Jan 9, 2025

add changeset

efab458

kjelko requested review from a team as code owners January 9, 2025 19:12

bump minor version

7b76774

DellaBitta reviewed Jan 13, 2025

View reviewed changes

packages/remote-config/src/api.ts Show resolved Hide resolved

packages/remote-config/test/api.test.ts Show resolved Hide resolved

DellaBitta requested changes Jan 15, 2025

View reviewed changes

ashish-kothari reviewed Jan 16, 2025

View reviewed changes

packages/remote-config/src/api.ts Show resolved Hide resolved

packages/remote-config/src/storage/storage.ts Outdated Show resolved Hide resolved

kjelko added 3 commits January 16, 2025 10:50

move FetchResponse types to public_types

6898123

extract custom signal merging logic to common function

62e1e84

run formatted again

551020e

kjelko requested review from DellaBitta and ashish-kothari January 16, 2025 19:38

ashish-kothari approved these changes Jan 20, 2025

View reviewed changes

jenh requested changes Jan 21, 2025

View reviewed changes

packages/remote-config/src/public_types.ts Outdated Show resolved Hide resolved

packages/remote-config/src/public_types.ts Outdated Show resolved Hide resolved

DellaBitta requested a review from jamesdaniels January 21, 2025 18:48

jenh requested changes Jan 21, 2025

View reviewed changes

packages/remote-config/src/api.ts Outdated Show resolved Hide resolved

packages/remote-config/src/api.ts Outdated Show resolved Hide resolved

Update comments after review

edb7abe

kjelko requested a review from jenh January 22, 2025 20:10

format and docgen

221d659

jenh approved these changes Jan 22, 2025

View reviewed changes

DellaBitta requested changes Jan 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SSR related improvements for RC client SDK. #8699

SSR related improvements for RC client SDK. #8699

kjelko commented Jan 9, 2025

changeset-bot bot commented Jan 9, 2025 •

edited

Loading

google-oss-bot commented Jan 9, 2025 •

edited

Loading

`@firebase/app`

`@firebase/auth`

`@firebase/auth-cordova`

`@firebase/auth-web-extension`

`@firebase/auth/internal`

`@firebase/data-connect`

`@firebase/database`

`@firebase/database-compat/standalone`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/performance`

`@firebase/remote-config`

`@firebase/storage`

`@firebase/vertexai`

`bundle`

`firebase`

google-oss-bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

DellaBitta left a comment •

edited

Loading

ashish-kothari left a comment

jenh left a comment

jenh left a comment

DellaBitta left a comment

DellaBitta Jan 23, 2025

		@@ -41,10 +42,40 @@ import { getModularInstance } from '@firebase/util';
		*

SSR related improvements for RC client SDK. #8699

Are you sure you want to change the base?

SSR related improvements for RC client SDK. #8699

Conversation

kjelko commented Jan 9, 2025

changeset-bot bot commented Jan 9, 2025 • edited Loading

🦋 Changeset detected

google-oss-bot commented Jan 9, 2025 • edited Loading

Size Report 1

Affected Products

@firebase/app

@firebase/auth

@firebase/auth-cordova

@firebase/auth-web-extension

@firebase/auth/internal

@firebase/data-connect

@firebase/database

@firebase/database-compat/standalone

@firebase/firestore

@firebase/firestore-lite

@firebase/functions

@firebase/performance

@firebase/remote-config

@firebase/storage

@firebase/vertexai

bundle

firebase

Test Logs

google-oss-bot commented Jan 9, 2025 • edited Loading

Size Analysis Report 1

Test Logs

github-actions bot commented Jan 9, 2025 • edited Loading

Changeset File Check ✅

DellaBitta left a comment • edited Loading

Choose a reason for hiding this comment

ashish-kothari left a comment

Choose a reason for hiding this comment

jenh left a comment

Choose a reason for hiding this comment

jenh left a comment

Choose a reason for hiding this comment

DellaBitta left a comment

Choose a reason for hiding this comment

DellaBitta Jan 23, 2025

Choose a reason for hiding this comment

changeset-bot bot commented Jan 9, 2025 •

edited

Loading

google-oss-bot commented Jan 9, 2025 •

edited

Loading

Size Report ¹

`@firebase/app`

`@firebase/auth`

`@firebase/auth-cordova`

`@firebase/auth-web-extension`

`@firebase/auth/internal`

`@firebase/data-connect`

`@firebase/database`

`@firebase/database-compat/standalone`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/performance`

`@firebase/remote-config`

`@firebase/storage`

`@firebase/vertexai`

`bundle`

`firebase`

google-oss-bot commented Jan 9, 2025 •

edited

Loading

Size Analysis Report ¹

github-actions bot commented Jan 9, 2025 •

edited

Loading

DellaBitta left a comment •

edited

Loading