-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set e2e test workflow to poll npm to check the version is available #8684
Conversation
|
Size Report 1Affected ProductsNo changes between base commit (32bf021) and merge commit (e87d92e).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (32bf021) and merge commit (e87d92e).Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copyright nit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated copyright date
Recently npm propagation after publish has been taking longer (there is some delay after a successful publish on the command line before that version is actually available to install). Adding polling using
npm view
to check every 60 seconds for 15 minutes and ensure the version is available for install before running the E2E firebase install. Hopefully that's enough.