Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set e2e test workflow to poll npm to check the version is available #8684

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

hsubox76
Copy link
Contributor

Recently npm propagation after publish has been taking longer (there is some delay after a successful publish on the command line before that version is actually available to install). Adding polling using npm view to check every 60 seconds for 15 minutes and ensure the version is available for install before running the E2E firebase install. Hopefully that's enough.

@hsubox76 hsubox76 requested a review from a team as a code owner December 19, 2024 20:09
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 96e83a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 19, 2024

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 19, 2024

@hsubox76 hsubox76 requested a review from DellaBitta December 19, 2024 22:07
Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright nit.

scripts/release/poll-npm-publish.js Outdated Show resolved Hide resolved
Copy link
Contributor Author

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated copyright date

@hsubox76 hsubox76 merged commit ddc3192 into main Jan 7, 2025
38 of 39 checks passed
@hsubox76 hsubox76 deleted the ch-npm-poll branch January 7, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants