-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo Refactor #171
Merged
Merged
Monorepo Refactor #171
Changes from all commits
Commits
Show all changes
139 commits
Select commit
Hold shift + click to select a range
93aef0a
Refactor monorepo to use yarn workspaces and lerna
jshcrowthe 7fd5029
Refactor to better separate ESM/CJS builds
jshcrowthe a1a7af0
Adding test:setup script
jshcrowthe c4e5a67
Fix breaking test (sourcemaps loaded in the test breaks the regex)
jshcrowthe e97702c
Remove commitizen message from CONTRIBUTING.md
jshcrowthe 45f3fcd
WIP: Migrate integration tests
jshcrowthe cf510a0
Adding namespace integration tests
jshcrowthe f6c00ef
Add messaging integration tests
jshcrowthe 2c42877
Fix issue with indv-module builds
jshcrowthe 9fcd1de
Committing yarn.lock
jshcrowthe e5f9948
Import 4.4.0 Changes
jshcrowthe a29d595
Add dev scripts, move core -> firebase
jshcrowthe 1722110
Add missing dependencies, flesh out dev experience
jshcrowthe 9cdff78
Add top level repl for test/debugging
jshcrowthe 89b7e7b
Make the REPL pretty
jshcrowthe 137f969
Refactor to scope prepublish execution
jshcrowthe 74246ae
Add @firebase/auth
jshcrowthe c03cb7f
Fixing broken int tests
jshcrowthe f4e8a50
Picking up missing changes from edad44d9bc30689635e994c9d4ba99adfb799af7
jshcrowthe 62882f4
Adding comment to .prettierignore
jshcrowthe d4522a4
Fixed issue where firebase didn't exist on reset
jshcrowthe 4317ce4
Update yarn.lock for lint-staged
jshcrowthe f7920c7
Refactor test setup script and .travis.yml
jshcrowthe d010d7d
Fix firebase package dep versions
jshcrowthe 129f269
Refactor precommit hook -> prepush hook
jshcrowthe c930fa5
[AUTOMATED]: Format Styling
jshcrowthe 6f373bc
Update prettier and prettierrc
jshcrowthe c9fe1a3
[AUTOMATED]: Format Styling
jshcrowthe 50ae0f5
Adding dist to .prettierignore
jshcrowthe caeb790
Fixing some oddities in yarn.lock
jshcrowthe 4262887
Merge branch 'master' into lerna
jshcrowthe 6bae224
Refactor hooks prepublish -> prepare
jshcrowthe 76d12af
Updating top-level scripts
jshcrowthe 687f08c
Add pretest validation/checking
jshcrowthe bb45220
[AUTOMATED]: Prettier Code Styling
jshcrowthe 1a85ecd
Running travis tests w/ xvfb-run
jshcrowthe 1047067
Add a spinner instead of the prettier stdio
jshcrowthe 475e93f
update yarn.lock
jshcrowthe 4c10e28
[AUTOMATED]: Prettier Code Styling
jshcrowthe 4b82da7
Fixing child process STDOUT
jshcrowthe ffa04f1
[AUTOMATED]: Prettier Code Styling
jshcrowthe 4ff901a
Switch to using stopAndPersist()
jshcrowthe ae94517
Moving file gitHooks/index.js -> gitHooks/prepush.js
jshcrowthe 2720340
Remove legacy .lintstagedrc
jshcrowthe e1e3bdc
Add typinngs file for those only including fiebase/app
jshcrowthe 44bff09
Add initial stub for @firebase/polyfill
jshcrowthe 25563d3
Adding new clean yarn.lock
jshcrowthe 1394b32
Refactor const -> var (no transpiling)
jshcrowthe ff548bb
Add automated license header validation
jshcrowthe 56e63ac
[AUTOMATED]: Prettier Code Styling
jshcrowthe c08cf16
[AUTOMATED]: License Headers
jshcrowthe 0eddd2a
Aesthetic prepush validation things
jshcrowthe 47ff084
[AUTOMATED]: Prettier Code Styling
jshcrowthe 9bfec3d
Add karma-sauce-launcher
jshcrowthe 6e1d5f7
Attempt 1: Try to get saucelabs browser testing working
jshcrowthe 5422c51
Attempt 2: Adding sauceLabs config prop to karma.base
jshcrowthe 9e4c93b
[AUTOMATED]: Prettier Code Styling
jshcrowthe 10aedcb
Attempt 3: Getting rid of the connectOptions
jshcrowthe cab7043
Merge branch 'master' into lerna
jshcrowthe 4cfaa46
[AUTOMATED]: Prettier Code Styling
jshcrowthe dd4d8b6
Fix CODEOWNERS
jshcrowthe 85e3b91
Add module boilerplate for @firebase/firestore
jshcrowthe 2430768
Refactor Firestore source to standalone package
jshcrowthe 7b4717f
Remove unneeded typings
jshcrowthe edd052b
Remove unneeded promise dependency
jshcrowthe e7adf9b
Fix top level paths
jshcrowthe 35835ab
Bump firebase package version
jshcrowthe d45f0b8
Fix firestore source paths
jshcrowthe bc038c1
Fix @firebase/app reference
jshcrowthe 63de02d
Refactor to fix TSC errors
jshcrowthe 8302c7f
Refactor to make node unit tests work
jshcrowthe 0debc1a
Publish
jshcrowthe e4916e5
Add firestore to main firebase binary
jshcrowthe 17e8743
Pin firebase package to strict versions
jshcrowthe bdfbeb0
Fix browser firestore tests
jshcrowthe 93f07f9
[AUTOMATED]: Prettier Code Styling
jshcrowthe 875fd7c
[AUTOMATED]: License Headers
jshcrowthe 8a80435
Changing base karma browsers
jshcrowthe 37a8300
Disabling cross-browser karma tests
jshcrowthe cfb0743
[AUTOMATED]: Prettier Code Styling
jshcrowthe 37ce4a6
Removing sauce_connect addon from .travis.yml
jshcrowthe 815a520
Refactor messaging test script
jshcrowthe 90bfd79
Refactor the browserNoActivityTimeout
jshcrowthe b799c10
[AUTOMATED]: Prettier Code Styling
jshcrowthe c8b6c49
Adding polyfills to the main browser bundles
jshcrowthe 3333ddc
Add firestore/README.md
jshcrowthe b519a5e
Fix firestore VSCode scripts
jshcrowthe ea47799
Fix regex for firestore __data__ prop
jshcrowthe 0b41da5
[AUTOMATED]: Prettier Code Styling
jshcrowthe fbd962f
Initial Commit
jshcrowthe 01d42ad
Add a brief README.md
jshcrowthe 8b29900
Add *.tgz to .npmignore
jshcrowthe d7292e5
Publish: v0.1.1
jshcrowthe 5965b81
Turn on advanced optimizations for this code
jshcrowthe b7f74a3
Leverage "ADVANCED_OPTIMIZATIONS" mode in closure compilation
jshcrowthe ecb3ec8
0.2.0
jshcrowthe d42cd27
Add XhrIo prototype overrides
jshcrowthe 548a1e3
0.2.1
jshcrowthe 60efd9c
Remove unneeded lockfile
jshcrowthe 27fed93
Fixing dependency versions
jshcrowthe 1e67688
[AUTOMATED]: Prettier Code Styling
jshcrowthe 5d5b270
[AUTOMATED]: License Headers
jshcrowthe 2f161c2
TEMP: Remove saucelabs reporter
jshcrowthe f8d93b5
Fix prettier styling bug (fights with closure)
jshcrowthe e1ded31
Merge branch 'master' into lerna
jshcrowthe 2468ee5
Update firebase/app typings
jshcrowthe 4e4ebd9
Leverage default exports
jshcrowthe dd919bf
Updating top-level README.md
jshcrowthe 15fa8cd
Refactor mocha timeout to be 20 seconds for firestore
jshcrowthe 45c47db
Addressing some review comments from @mikelehen
jshcrowthe 3731f8a
temp
jshcrowthe 3d15323
Fixing license header spacing issues
jshcrowthe 34c671a
Refactor license header check
jshcrowthe 76dafe7
[AUTOMATED]: Prettier Code Styling
jshcrowthe 559068c
[AUTOMATED]: License Headers
jshcrowthe c0b158d
Revert "[AUTOMATED]: License Headers"
jshcrowthe a88f143
Revert "Refactor license header check"
jshcrowthe 2f61774
Fixing more license headers
jshcrowthe 6a3e406
Add @wilhuff and @wti806 to CODEOWNERS
jshcrowthe a269a30
Adding one more --auto-watch flag
jshcrowthe 990d013
Add 3 retries to firestore tests
jshcrowthe 3d13ba3
Merge branch 'master' into lerna
jshcrowthe b0fd88c
Bumping browserNoActiityTimeout
jshcrowthe 5313a36
@firebase/app - package.json housekeeping
jshcrowthe b971e24
@firebase/auth - README.md housekeeping
jshcrowthe 3281a99
@firebase/database - README.md housekeeping
jshcrowthe fbb0cb5
@firebase/firestore - README.md housekeeping
jshcrowthe 30fe9f2
Updating auth readme
jshcrowthe 5dcec56
@firebase/messaging - README.md housekeeping
jshcrowthe 986510c
Updating database readme
jshcrowthe afcc686
Fixing issue with messaging/package.json (copy-paste fail)
jshcrowthe f0e6d62
@firebase/polyfill - README.md housekeeping
jshcrowthe 396a11a
@firebase/storage - README.md housekeeping
jshcrowthe 43171d2
@firebase/util - README.md housekeeping
jshcrowthe 6a9e795
Fixing package.json repo links
jshcrowthe ec5403f
Refactor from PromiseLike -> Promise
jshcrowthe 2160481
Add firebase externs
jshcrowthe 0e7c298
[AUTOMATED]: Prettier Code Styling
jshcrowthe 2d7e66f
Fix license values in package.json
jshcrowthe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,15 @@ | ||
# Build/Dependencies | ||
node_modules | ||
dist | ||
.awcache | ||
/config/project.json | ||
|
||
# Misc | ||
*.log | ||
|
||
# OS Specific Files | ||
.DS_Store | ||
node_modules/ | ||
/dist | ||
npm-debug.log | ||
/coverage | ||
/.nyc_output | ||
/tests/config | ||
temp/ | ||
/.vscode | ||
/.ts-node | ||
/.idea | ||
/.awcache | ||
|
||
# Editor Configs | ||
.idea | ||
.vscode |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# This file is pre-built and need not be formatted | ||
packages/auth/src/auth.js | ||
dist |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
singleQuote: true, | ||
printWidth: 80 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW- We could probably move this whole .vscode directory under packages/firestore (each package can have its own .vscode if it wants it)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is currently not supported by VSCode:
microsoft/vscode#396
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, that wasn't very clear. I was thinking that we'd push people towards opening vscode inside of a specific package. So if I'm doing firestore development, I'd open vscode in packages/firestore and then our launch configuration would be available and only our sources would show up in vscode, etc. I think this might make sense, since this launch.json is 100% Firestore-specific anyway... But I don't feel strongly about this. We can always do it later.