Skip to content

[Vertex AI] Add documentation for Imagen symbols #14411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 5, 2025

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Jan 31, 2025

  • Added DocC comments to all public symbols.
  • Added a notice about the Imagen feature being a Public Preview.
  • Fixed the casing of gcsURI in generateImages(prompt:gcsURI:) (was gcsUri) to match the API proposal and Swift style guide.

#14221
#no-changelog

@andrewheard andrewheard marked this pull request as ready for review February 4, 2025 23:33
@andrewheard andrewheard requested a review from paulb777 February 4, 2025 23:33
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice API docs.

Is there a good way to get this level of quality consistently across all platforms without too much duplicate work?

@andrewheard
Copy link
Contributor Author

Nice API docs.

Is there a good way to get this level of quality consistently across all platforms without too much duplicate work?

Thanks!

I don't think we'd be able to make them consistent for this release without duplicate work since the rest of the SDKs have already added docs. Fortunately I was able to grab from the others (and Cloud or Developer API docs) and then elaborated where I saw fit. Something we could consider in the future is adding docs to one set of API signatures in a Firebase API Proposal and then, once approved, each platform owner can copy/paste them and make the slight language-specific formatting changes. That would allow us to iterate on the docs together, might make the proposals easier to read since the docs would provide context/detail about the API surface (but may be too noisy, especially with Markdown and links) and reduce some duplicate work. That's just one idea though, we should probably bring it up in one of our meetings. cc: @rachelsaunders in case she has ideas too (and for visibility on the docs).

@andrewheard andrewheard merged commit 33594fb into vertex-imagen Feb 5, 2025
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-imagen-docs branch February 5, 2025 02:57
@firebase firebase locked and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants