Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for DataSnapshot.val() throwing error when source is null #1682

Merged
merged 1 commit into from
Mar 31, 2025
Merged

fix for DataSnapshot.val() throwing error when source is null #1682

merged 1 commit into from
Mar 31, 2025

Conversation

CorieW
Copy link
Contributor

@CorieW CorieW commented Mar 24, 2025

Resolves #1677

@CorieW CorieW requested a review from cabljac March 24, 2025 16:55
cabljac
cabljac approved these changes Mar 25, 2025
View reviewed changes
Copy link

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@cabljac cabljac added this pull request to the merge queue Mar 31, 2025
Merged via the queue into master with commit 461fa11 Mar 31, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taeold taeold taeold approved these changes

@cabljac cabljac cabljac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataSnapshot.val() throws error for nested child when parent doesn't exist
3 participants
@CorieW @taeold @cabljac