Skip to content

Add code snippets for firestore modules. #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2022

Conversation

jkyle109
Copy link
Contributor

@jkyle109 jkyle109 commented Jul 26, 2022

Added code snippets to support documentation for Firestore modules.

Related to #104

@jkyle109 jkyle109 self-assigned this Jul 26, 2022
@jkyle109 jkyle109 marked this pull request as ready for review July 26, 2022 15:56
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkyle109 jkyle109 requested a review from vkryachko July 26, 2022 20:38
@jkyle109 jkyle109 changed the base branch from async-firestore to master July 28, 2022 16:22
@jkyle109 jkyle109 changed the base branch from master to async-firestore July 28, 2022 16:23
@jkyle109 jkyle109 merged commit ac697bc into async-firestore Aug 5, 2022
jkyle109 added a commit that referenced this pull request Aug 24, 2022
* feat(firestore): Expose Async Firestore Client. (#621)

* feat(firestore): Expose Async Firestore Client.

* fix: Added type hints and defintion wording changes

* fix: removed future annotations until Python 3.6 is depreciated.

* fix: added missed type and clarifying comment for Python 3.6 type hinting.

* fix: lint

* Adds integration tests for the Async Firstore module (#623)

* Add integration tests for async firstore module

* fix: made pytest Python 3.6 compatible

* Trigger Integration Tests

* fix: correct copyright year

* Add code snippets for firestore modules. (#628)

* Add code snippets for firestore modules.

* fix: clarified snippet names and fixed newline.

* fix: Removed var tags. These won't work as I intended it to since html is escaped when using includecode.

Co-authored-by: Lahiru Maramba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants