Skip to content

Bump versions of Google API clients and remove hack #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Bump versions of Google API clients and remove hack #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb2cd93
Bump versions of `google-apis-firebaseappdistribution_v1` and `v1alph…
kaibolay Dec 12, 2024
ccd442d
Remove hacky override of `GoogleFirebaseAppdistroV1alphaReleaseTest`.
kaibolay Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fastlane-plugin-firebase_app_distribution.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ['lib']

spec.add_dependency('google-apis-firebaseappdistribution_v1', '~> 0.3.0')
spec.add_dependency('google-apis-firebaseappdistribution_v1alpha', '~> 0.2.0')
spec.add_dependency('google-apis-firebaseappdistribution_v1', '~> 0.9.0')
spec.add_dependency('google-apis-firebaseappdistribution_v1alpha', '~> 0.9.0')

spec.add_development_dependency('pry')
spec.add_development_dependency('bundler')
Expand Down
46 changes: 0 additions & 46 deletions lib/fastlane/plugin/firebase_app_distribution/helper/firebase_app_distribution_apis.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,48 +1,2 @@
require 'google/apis/firebaseappdistribution_v1'
require 'google/apis/firebaseappdistribution_v1alpha'

# This is partially copied from google/apis/firebaseappdistribution_v1alpha v0.9.0 (2024-12-08) based discovery document revision 20241204.
# We can't depend on that version directly as long as fastlane locks google-cloud-env < 2.0.0 (to support Ruby 2.6).
# Newer versions of the API clients depend on google-apis-core >= 0.15.0 which depends on googleauth ~> 1.9 which depends on google-cloud-env ~> 2.1.
# See also https://github.com/fastlane/fastlane/pull/21685#pullrequestreview-2490037163
module Google
module Apis
module FirebaseappdistributionV1alpha
class GoogleFirebaseAppdistroV1alphaReleaseTest
include Google::Apis::Core::Hashable

attr_accessor :create_time
attr_accessor :device_executions
attr_accessor :display_name
attr_accessor :login_credential
attr_accessor :name
attr_accessor :test_case
attr_accessor :test_state

def initialize(**args)
update!(**args)
end

def update!(**args)
@create_time = args[:create_time] if args.key?(:create_time)
@device_executions = args[:device_executions] if args.key?(:device_executions)
@display_name = args[:display_name] if args.key?(:display_name)
@login_credential = args[:login_credential] if args.key?(:login_credential)
@name = args[:name] if args.key?(:name)
@test_case = args[:test_case] if args.key?(:test_case)
@test_state = args[:test_state] if args.key?(:test_state)
end

class Representation < Google::Apis::Core::JsonRepresentation
property :create_time, as: 'createTime'
collection :device_executions, as: 'deviceExecutions', class: Google::Apis::FirebaseappdistributionV1alpha::GoogleFirebaseAppdistroV1alphaDeviceExecution, decorator: Google::Apis::FirebaseappdistributionV1alpha::GoogleFirebaseAppdistroV1alphaDeviceExecution::Representation
property :display_name, as: 'displayName'
property :login_credential, as: 'loginCredential', class: Google::Apis::FirebaseappdistributionV1alpha::GoogleFirebaseAppdistroV1alphaLoginCredential, decorator: Google::Apis::FirebaseappdistributionV1alpha::GoogleFirebaseAppdistroV1alphaLoginCredential::Representation
property :name, as: 'name'
property :test_case, as: 'testCase'
property :test_state, as: 'testState'
end
end
end
end
end
Loading