Skip to content

refactor: use generic account service protocol to delete users, update phone provider to also have delete user API #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 29, 2025
Merged

refactor: use generic account service protocol to delete users, update phone provider to also have delete user API #1286

merged 13 commits into from
Oct 29, 2025
+140 −309

Conversation

@russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Oct 27, 2025 •
edited
Loading

  • Removed DeleteUserSwift protocol and added deleteUser() method to AuthProviderSwift protocol.
  • Replaced [PROVIDER]DeleteUserOperation with generic ProviderDeleteUserOperation.
  • Added deleteUser() method to phone provider so it can also delete users like the other providers.
  • Updated packages to use latest swift 6.

@russellwheatley russellwheatley changed the title refactor: use generic account service to delete users refactor: use generic account service protocol to delete users, update phone provider to also have delete user API Oct 27, 2025
@russellwheatley russellwheatley merged commit 4803efa into development Oct 29, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@demolaf demolaf demolaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@russellwheatley @demolaf