feat: implements config loader to enable remote or external configs #935
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I will rebase to the latest main branch, check the failing test, and post an update afterward. |
dcoric
force-pushed
the
denis-coric/remote-config
branch
from
aa0283d to
8d161a6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
==========================================
+ Coverage 48.09% 48.51% +0.42%
==========================================
Files 49 51 +2
Lines 1813 2092 +279
Branches 196 241 +45
==========================================
+ Hits 872 1015 +143
- Misses 917 1040 +123
- Partials 24 37 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dcoric - can we bolster up the code coverage? 🚀 |
dcoric
force-pushed
the
denis-coric/remote-config
branch
from
7dea019 to
55ce8ee
Compare
Done. |
dcoric
force-pushed
the
denis-coric/remote-config
branch
from
7f0a5cf to
a73338d
Compare
dcoric
force-pushed
the
denis-coric/remote-config
branch
from
a73338d to
e9b0924
Compare
dcoric
force-pushed
the
denis-coric/remote-config
branch
from
2e882cf to
e820169
Compare
|
@dcoric - thanks for attending the call today! As discussed, let's take a look at the failing CI and we can get this merged 👍 |
feat: converted to typescript fix: config loader clone command issue fix: adds input validation, uses array arguments, prevented shell spawn fix: adds failsafe checking for directory location and structure fix: env-paths change to v2.2.1 which support require and minor code fix fix: improves test coverage Adds additional tests for better cove fix: fixed creating cache directory
|
@dcoric - are you seeing merge conflicts? |
Default value should be false, and set to true when cert path is configured
Yes, on it right now. |
dcoric
force-pushed
the
denis-coric/remote-config
branch
from
41697aa to
a4cfa78
Compare
| @@ -648,5 +648,105 @@ description: JSON schema reference documentation for GitProxy | |||
| </blockquote> | |||
| </details> | |||
|
|
|||
| ---------------------------------------------------------------------------------------------------------------------------- | |||
| <details> | |||
| <summary> | |||
There was a problem hiding this comment.
@dcoric was this content written manually? Its supposed to be generated from the config schema, but I'm not seeing matching info added to the schema above. Hence, it will all be lost the next time that the ref doc is re-generated (npm run gen-schema-doc - requires you to have a python env setup for it to run in). I'm doing that on another PR that adds to the config schema so that will happen soon... A new PR is probably needed to correct this @JamieSlome @sam-holmes2
This pull request introduces a significant update to the configuration management system of the GitProxy application. The main changes include adding support for multiple configuration sources, implementing a new configuration loader class, and providing the ability to reload configurations without restarting the application.
Configuration Management Enhancements:
Added support for multiple configuration sources in
config.schema.jsonandproxy.config.json, allowing the configuration to be sourced from files, HTTP endpoints, or Git repositories. [1] [2]Introduced a new
ConfigLoaderclass insrc/config/ConfigLoader.jsto manage the loading and reloading of configurations from the specified sources. This class handles periodic reloading, merging configurations, and emitting events on configuration changes.CLI and API Improvements:
Added a new CLI command
reload-configinpackages/git-proxy-cli/index.jsto trigger a configuration reload without restarting the process. This command checks for authentication and makes a POST request to the admin API endpoint to reload the configuration. [1] [2]Added a new admin-only API endpoint
/api/v1/admin/reload-configinsrc/service/index.jsto handle configuration reload requests. This endpoint validates the request, reloads the configuration, and restarts the services if necessary.Proxy Service Enhancements:
src/proxy/index.jsto support stopping and restarting the HTTP and HTTPS servers, enabling the application to apply new configurations without a full restart.Configuration Access and Updates:
src/config/index.jsto use the newConfigLoaderand updated existing getter functions to retrieve values from the current configuration. Added functionality to handle configuration updates dynamically and restart services as needed. [1] [2] [3]fix: config loader clone command issueThis PR fixes #934