feat: implements config loader to enable remote or external configs #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I will rebase to the latest main branch, check the failing test, and post an update afterward. |
06kellyjac
suggested changes
Mar 17, 2025
dcoric
force-pushed
the
denis-coric/remote-config
branch
from
aa0283d to
8d161a6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
==========================================
- Coverage 61.88% 60.54% -1.34%
==========================================
Files 49 51 +2
Lines 1805 1967 +162
==========================================
+ Hits 1117 1191 +74
- Misses 688 776 +88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dcoric - can we bolster up the code coverage? 🚀 |
dcoric
force-pushed
the
denis-coric/remote-config
branch
from
7dea019 to
55ce8ee
Compare
Done. |
fix: config loader clone command issue fix: adds input validation, uses array arguments, prevented shell spawn fix: adds failsafe checking for directory location and structure fix: env-paths change to v2.2.1 which support require and minor code fix fix: improves test coverage Adds additional tests for better cove fix: fixed creating cache directory
dcoric
force-pushed
the
denis-coric/remote-config
branch
from
7f0a5cf to
a73338d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a significant update to the configuration management system of the GitProxy application. The main changes include adding support for multiple configuration sources, implementing a new configuration loader class, and providing the ability to reload configurations without restarting the application.
Configuration Management Enhancements:
Added support for multiple configuration sources in
config.schema.jsonandproxy.config.json, allowing the configuration to be sourced from files, HTTP endpoints, or Git repositories. [1] [2]Introduced a new
ConfigLoaderclass insrc/config/ConfigLoader.jsto manage the loading and reloading of configurations from the specified sources. This class handles periodic reloading, merging configurations, and emitting events on configuration changes.CLI and API Improvements:
Added a new CLI command
reload-configinpackages/git-proxy-cli/index.jsto trigger a configuration reload without restarting the process. This command checks for authentication and makes a POST request to the admin API endpoint to reload the configuration. [1] [2]Added a new admin-only API endpoint
/api/v1/admin/reload-configinsrc/service/index.jsto handle configuration reload requests. This endpoint validates the request, reloads the configuration, and restarts the services if necessary.Proxy Service Enhancements:
src/proxy/index.jsto support stopping and restarting the HTTP and HTTPS servers, enabling the application to apply new configurations without a full restart.Configuration Access and Updates:
src/config/index.jsto use the newConfigLoaderand updated existing getter functions to retrieve values from the current configuration. Added functionality to handle configuration updates dynamically and restart services as needed. [1] [2] [3]fix: config loader clone command issueThis PR fixes #934