-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add authorization for UI routes #917
Open
jescalada
wants to merge
13
commits into
finos:main
Choose a base branch
from
jescalada:admin-routes-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+223
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merges OIDC libary updates.
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #917 +/- ##
=======================================
Coverage 61.88% 61.88%
=======================================
Files 49 49
Lines 1805 1805
=======================================
Hits 1117 1117
Misses 688 688 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #918.
This PR fixes the UI route access issue (unlogged users and non-admins can no longer access any route). In other words, only admins should be able to access the list of users, and only logged-in users can see the rest. Unlogged users can only access the login page.
You'll see an Unauthorized page when accessing a route you don't have access to.
Another issue we'd like to fix is the layout and the admin routes, which are coupled. Thus, all routes are called
/admin/*
when we only want the actual admin routes to have this naming (and replace regular routes with/dashboard/
). To keep things bite-sized, this will be pushed in a separate PR.It builds on top of the OIDC implementation at #905. As mentioned in that PR, testing with OIDC will require editing the config.
Tests will be modified/added in the layout fix PR since the routes will change.
Thank you!
Changelog
AuthProvider
PrivateRoute
NotAuthorized
andNotFound
pages