2 0 conformance rm for the web merging main #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix links to test specifications (after refactor/merge of the files)
…lower performance machines
Make tests more robust on lower performance machines
core-plus key fix
The existing check was incorrect in a couple of ways: 1. It wasn't checking that both appIdentifiers were present, only that either was 2. `JSON.stringify` doesn't guarantee ordering of parameters in stringified object, the order they were added when creating the object affects the order that they stringify in, hence two objects with identical properties may not produce equal strings.
…d not declared in its appD record (probably a copy paste error)
… not a standard type
Fix error in 2.0 findInstances validation function
Fix intent channel result tests, a couple of app definitions and use of magic strings
Adding the respective number to the displayName of sharedTestingIntent1 and sharedTestingIntent2 so that Intent Resolvers using the displayName can separate the two...
Update DisplayName for Shared Testing Intents
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.