Linting fixes

[hameerabbasi]

• Add pre-commit hook for mypy to catch typing errors
• Linting fixes for entire library.

[willow-ahrens]

this is great, thanks! I especially like the match case that was introduced.

[mtsokol]

Posted some comments. Let's rebase it and solve conflicts and squash to single commit - the diff should be smaller.

[hameerabbasi]

squash to single commit

This can be done by the squash-merge strategy in GitHub. Also, squashing merge-commits is hard.

[mtsokol]

squash to single commit

This can be done by the squash-merge strategy in GitHub.

Sure!

Also, squashing merge-commits is hard.

Right, that's why I personally prefer to always git rebase -i main over merging main into the branch.

[willow-ahrens]

Is there a repo-wide setting I need to update here?

[mtsokol]

Is there a repo-wide setting I need to update here?

Let's make this a principle we stick to - I don't think there is.

[EDIT] Looks that here's a branch rule for it:
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches#require-linear-history

But some people complain about it: https://github.com/orgs/community/discussions/61107#discussioncomment-6671872 although I'm not sure this applies to us.

[hameerabbasi]

Right, that's why I personally prefer to always git rebase -i main over merging main into the branch.

I usually prefer that too -- but I do make exceptions for large PRs where one merge conflict is easier to handle than many small ones.

[mtsokol]

@hameerabbasi I finished reviewing it: I'm only concerned about LogicNode class and node.py changes (I still prefer the have LogicNode class used as a main node representation).

The rest of the changes LGMT.

[mtsokol]

Merged, Thanks @hameerabbasi!