Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ziputils #775

Conversation

rpatters1
Copy link
Collaborator

@rpatters1 rpatters1 commented Oct 18, 2024

  • refactor ziputils into ziputils and enigmaxml libraries
  • refactor both to use client library for managing dependencies like luaosutils
  • refactor PowerShell commands to work with io.popen as well as luaosutils.process.execute
  • PowerShell script for calc_gunzip_command now returns raw decompressed bytes in stdout.
  • other minor changes as part of refactor

I wonder is the reason "%s" works now (and & { %s } doesn't) is because all the commands are on a single line now. (This is to accommodate io.popen which apparently doesn't work with embedded newlines.)

@asherber
Copy link
Member

I don't think that's the issue, but I'll try some tests later, just for my own edification.

@rpatters1
Copy link
Collaborator Author

FWIW: When I change it to & { %s }, the command emits the powershell help page.

@rpatters1
Copy link
Collaborator Author

It works the same irrespective of calling luaosutils or io.popen. That is, the current version works and the & { %s } version emits the help page.

@rpatters1 rpatters1 merged commit 0dafdaf into finale-lua:master Oct 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants