Implement fallback_call #647
Conversation
|
It might be safe, but I really don't like the idea of mixing case styles in the same context, it's messy. Perhaps it might be better to add a |
* master: chore: autopublish 2024-01-20T22:33:40Z fix typo and remove "..." from window title clarify how to require an embedded library in the docs missed one lint fixes and build broken
|
The I also changed the name to use pascal case with a leading underscore. The PDK Library has some public class methods that start with underscore, but none of them are exposed to Lua. I don't plan to start, either. |
src/mixin/__FCMBase.lua
Outdated
| ]] | ||
| function methods:_FallbackCall(method_name, fallback_value, ...) | ||
| if not self[method_name] then | ||
| return fallback_value or self |
There was a problem hiding this comment.
This should explicitly check for nil so that it doesn't return self if false is passed, which could be a legitimate fallback value.
|
Another excellent catch. I've fixed it, and I'm going to go ahead an merge it because I need to have it in place for the next PR I will be submitting soon. If there are further tweaks we can do it there. |
This PR implements a fallback call for
mixinsimilar to the solution proposed in #643. I modified the proposed solution as follows:fallback_callas the name of the proxy method as well as the mixin function. No PDK Framework class will ever use snake case for a property, method, or constant value, at least as long as I am on the project. That means any snake case method name is safe for use by mixin.This solution has an added benefit that if a mixin version of a missing method is ever implemented, this function should pick it up.
An open question is
mixin.fallback_callbe private instead of public?