Begin merging FCXCtrlCustomLuaWindow into FCMCtrlCustomLuaWindow
#430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code looks okay to me, but somewhere along the line |
|
Actually, on further testing, it appears that this PR is what introduced the defect that causes window position not to be remembered. |
ThistleSifter
force-pushed
the
fcm-ctrl-custom-lua-window
branch
from
4b95a25 to
03b11ac
Compare
|
This should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts the process of reducing the number of
FCXmixins as discussed in #399 and simplifying and reducing mixin code. I'll be doing it in a number of stages.