Remove comments when bundling #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all comments from bundling as discussed in #332 (comment). This includes both multiline documentation comments and single-line comments.
Additionally, some extra whitespace is removed, along with successive empty lines.
It's possible this will break the bundled scripts (again), but at least this change has fairly good test coverage and it's possible to add any new errors as test cases to the bundler.
Going to merge this one without review since several of us are in agreement on the idea, and I'm really the only person who understands the bundler at this point so I'm unsure how useful code review will be.
cc @ThistleSifter @cv-on-hub @rpatters1