Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jetstream #280

Closed
wants to merge 1 commit into from
Closed

Add jetstream #280

wants to merge 1 commit into from

Conversation

Nick-Mazuk
Copy link
Member

This PR adds the JetStream files as discussed in #259.

The CODEOWNERS file ensures that any changes to the JetStream files (jetstream.lua and jetstream_config.lua) are approved by either CJ or Jacob.

Additionally, as discussed in #259, the standard code review process will not apply to this PR, but any future changes to the JetStream files will go through normal code review.

Either @jwink75 or @CJGarciaMusic should be the one to merge this PR.

@rpatters1
Copy link
Collaborator

I don't know where this stands with regards to committing it. I am going to use the conversation to discuss a possible change that would avoid the annoying dialog box.

I am thinking about adding a startup option to RGP Lua that would allow a script to run at startup. This script would run a coroutine that wakes up periodically and looks for a temp file that contains the command to execute. The only issue would be if the Jet Stream code can write the temp file.

Also, @Nick-Mazuk I am wondering if the jetstream project should not be under its own repository inside the finale-lua organization. It could include the libraries by means of a submodule inclusion of this repo. If that is impractical, then could we at least separate it in src/jetstream?

@jwink75
Copy link
Collaborator

jwink75 commented Feb 13, 2023 via email

@rpatters1
Copy link
Collaborator

I literally just watched one of @Nick-Mazuk's videos where the dialog box was listed as a negative. I suppose I was reacting to that. I'm assuming you must know the codes for some of the functions by heart. Is this a likely scenario for the average user?

@rpatters1
Copy link
Collaborator

To answer your question, the Jet Stream controller generates a code, correct? I'm guessing it propagates the code into the dialog box by invoking the menu option and filling it with text. Is this an Applescript or something?

What the JetStream could do instead is write the code to a temp file. Then the coroutine running in Finale could pick it up and either execute the function directly or invoke the menu option which would read and then delete the text file. Or if you want to get fancy it might be possible to use luasocket, but that would require some programming in the JetStream controller that might not be feasible.

@jwink75
Copy link
Collaborator

jwink75 commented Feb 13, 2023 via email

@rpatters1
Copy link
Collaborator

I am going to close this pull request. I would encourage @jwink75 to move the Jet Stream repo to the Finale Lua organization as an alternative.

@rpatters1 rpatters1 closed this Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants