Skip to content

Code Quality: Improved Axe assertion message #17283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jul 20, 2025

Resolved / Related Issues

None

Steps used to test these changes

None

Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the position would necessarily help me debug a failure more easily but the code looks fine.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 20, 2025
@0x5bfa
Copy link
Member Author

0x5bfa commented Jul 20, 2025

This PR fails with a unknown AXE issue but because now we know the poisiton of items causing that issue, I figured out that it was caused by an element located in the right top (and presumably Mode buttons not having a11y name.), which was fixed in the other PR.

@yaira2
Copy link
Member

yaira2 commented Jul 21, 2025

Why is this failing if no xaml has been changed?

@yaira2 yaira2 merged commit d7e0e9d into files-community:main Jul 21, 2025
5 of 6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-Axe branch July 21, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants