-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Feature: Introduced Omnibar 1 #17023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yaira2
merged 4 commits into
files-community:main
from
0x5bfa:5bfa/CQ-OmnibarIntroduction
Apr 30, 2025
Merged
Feature: Introduced Omnibar 1 #17023
yaira2
merged 4 commits into
files-community:main
from
0x5bfa:5bfa/CQ-OmnibarIntroduction
Apr 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f93960a
to
e1ee482
Compare
yaira2
reviewed
Apr 10, 2025
yaira2
reviewed
Apr 10, 2025
yaira2
reviewed
Apr 21, 2025
yaira2
reviewed
Apr 21, 2025
src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs
Outdated
Show resolved
Hide resolved
yaira2
reviewed
Apr 21, 2025
I found an issue where text entered into the address bar isn't cleared after removing the focus. The easiest way to test this is by removing the focus and then refocusing the address bar. |
0aeb079
to
e4ba94d
Compare
yaira2
reviewed
Apr 22, 2025
src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs
Outdated
Show resolved
Hide resolved
yaira2
reviewed
Apr 22, 2025
75d29b5
to
aa7d7fa
Compare
35ce79a
to
dc2399d
Compare
yaira2
reviewed
Apr 23, 2025
yaira2
reviewed
Apr 23, 2025
yaira2
reviewed
Apr 23, 2025
49fd456
to
c93e9c0
Compare
yaira2
reviewed
Apr 23, 2025
4eef142
to
b1b7ad5
Compare
b1b7ad5
to
13e1f84
Compare
Co-Authored-By: Yair <39923744+yaira2@users.noreply.github.com>
fde064d
to
6a80bcd
Compare
yaira2
reviewed
Apr 29, 2025
yaira2
reviewed
Apr 29, 2025
yaira2
reviewed
Apr 29, 2025
479cb18
to
b230228
Compare
b230228
to
e4c6ec1
Compare
yaira2
reviewed
Apr 30, 2025
yaira2
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to see the Omnibar in action!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Introduced Omnibar and added support for the Path mode.
Steps used to test these changes