-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix: Fixed thumbails not loading in MTP devices #16782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I was thinking we could take this a step forward with a single method in |
Ok now thumbnails work in file list, in properties window and preview pane 💪 |
I'm concerned about maintaining two separate thumbnail systems (we did in the past, with much trouble). |
30cea65
to
decf3da
Compare
75d29b5
to
aa7d7fa
Compare
@gave92 this is potentially solvable when we switch ShellViewModel to the new storage abstractions. |
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build
. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Added back some code removed in #14423 which is necessary for loading thumbails in MTP.
Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.