Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Zinnia.versions.{zinnia,v8} #261

Merged
merged 3 commits into from
Jun 23, 2023
Merged

feat: Zinnia.versions.{zinnia,v8} #261

merged 3 commits into from
Jun 23, 2023

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Jun 22, 2023

Add a new Zinnia API exposing runtime and V8 versions to modules.

Related: filecoin-station/spark-api#29

In the future, we can expose this via import versions from "zinnia:versions" - see #236.

Add a new Zinnia API exposing runtime and V8 versions to modules.

Signed-off-by: Miroslav Bajtoš <[email protected]>
@bajtos bajtos requested a review from juliangruber June 22, 2023 14:17
Signed-off-by: Miroslav Bajtoš <[email protected]>
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

runtime/tests/js/versions_tests.js Outdated Show resolved Hide resolved
@bajtos bajtos enabled auto-merge (squash) June 23, 2023 08:30
@bajtos bajtos merged commit 8e3036e into main Jun 23, 2023
@bajtos bajtos deleted the feat-expose-version branch June 23, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants