Skip to content

Prevent Path Traversal #6390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prevent Path Traversal #6390

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daf136f
Prevent Path Traversal
bhaskarvilles Aug 11, 2024
135c26f
FIX TYPO
bhaskarvilles Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion venus-devtool/inline-gen/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,13 @@ const (
var data = map[string]interface{}{}

func main() {
db, err := os.ReadFile(os.Args[2])
// Validate and sanitize the file path
jsonFilePath, err := sanitizePath(os.Args[2])
if err != nil {
log.Fatalf("Invalid file path: %v", err)
}

db, err := os.ReadFile(jsonFilePath)
if err != nil {
log.Fatalf("Error reading file: %v", err)
}
Expand All @@ -34,6 +40,25 @@ func main() {
}
}

func sanitizePath(p string) (string, error) {
// Ensure the path is absolute
absPath, err := filepath.Abs(p)
if err != nil {
return "", err
}

// Resolve any symlinks and clean the path
cleanPath := filepath.Clean(absPath)

// Check if the path is within a specific allowed directory
allowedDir := "/venus/inline-gen/"
if !strings.HasPrefix(cleanPath, allowedDir) {
return "", fmt.Errorf("attempted path traversal outside of allowed directory")
}

return cleanPath, nil
}

func processFile(path string, info os.FileInfo, err error) error {
if err != nil {
return err
Expand Down