Skip to content

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Sep 30, 2025

closes: #2219

feat: nv28 skeleton
@Copilot Copilot AI review requested due to automatic review settings September 30, 2025 07:32
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Sep 30, 2025
@rjan90 rjan90 requested review from TippyFlitsUK and removed request for Copilot September 30, 2025 07:32
@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting Review in FilOz Sep 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.58%. Comparing base (c414105) to head (e92221a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2220   +/-   ##
=======================================
  Coverage   77.58%   77.58%           
=======================================
  Files         147      147           
  Lines       15789    15789           
=======================================
  Hits        12250    12250           
  Misses       3539     3539           
Files with missing lines Coverage Δ
fvm/src/gas/price_list.rs 85.59% <ø> (ø)
fvm/src/machine/default.rs 69.47% <ø> (ø)
shared/src/version/mod.rs 0.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rjan90
Copy link
Contributor Author

rjan90 commented Sep 30, 2025

For unblocking this PR/get past the #2221 failure in cargo-deny, I suggest to either:

  • Address it separately (i.e merge even with the failure) or update the deny.toml config to allow this temporarily.
  • Update wasmtime to a newer version (update wasmtime to at least 33.0.2 #2186) that doesn't use fxhash.
    • This might require significant changes.

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✔️ Approved by reviewer
Development

Successfully merging this pull request may close these issues.

Skeleton for nv28 to support development and testing
3 participants