-
Notifications
You must be signed in to change notification settings - Fork 143
feat: FIP-0079: syscall for aggregated bls verification #2003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@DrPeterVanNostrand could you please help taking a look at this PR? |
056690e
to
e00667d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but grain-of-salt from me given my limited expertise on this
@@ -220,6 +220,7 @@ pub trait ActorOps { | |||
fn balance_of(&self, actor_id: ActorID) -> Result<TokenAmount>; | |||
} | |||
|
|||
#[cfg(feature = "verify-signature")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not put this on the verify_signature
operation itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that the answer is no. Oh well...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, otherwise lgtm!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2003 +/- ##
===========================================
- Coverage 75.62% 57.04% -18.58%
===========================================
Files 157 119 -38
Lines 15750 10381 -5369
===========================================
- Hits 11911 5922 -5989
- Misses 3839 4459 +620
|
This PR tries to implement https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0079.md without breaking FVM backward compatibility.
(NOTE: This PR is largely based on #1914)
Closes #2001
Changes:
verify_bls_aggregate
syscallverify-signature
that keepsverify_signature
syscall for backward compatibilityverify-signature
featureverify-signature
feature