fix: set the default thread-pool size by the available concurrency #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And default to 8 if we can't get this information. This isn't a perfect metric (e.g., it doesn't take IO into account) but it's better than nothing).
Stebalien
force-pushed
the
steb/default-thread-pool
branch
from
3a993a9 to
dbaa69e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1931 +/- ##
===========================================
- Coverage 75.45% 54.46% -21.00%
===========================================
Files 156 157 +1
Lines 15234 15480 +246
===========================================
- Hits 11495 8431 -3064
- Misses 3739 7049 +3310
|
Stebalien
requested review from
arajasek and
fridrik01
and removed request for
arajasek
fridrik01
approved these changes
Dec 13, 2023
| @@ -9,10 +9,10 @@ use super::{ApplyKind, ApplyRet, Executor}; | |||
|
|
|||
| lazy_static! { | |||
| static ref EXEC_POOL: yastl::Pool = yastl::Pool::with_config( | |||
| 8, | |||
| std::thread::available_parallelism().map(|n|n.get()).unwrap_or(8), | |||
There was a problem hiding this comment.
we should probably mention this change in fvm/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And default to 8 if we can't get this information. This isn't a perfect metric (e.g., it doesn't take IO into account) but it's better than nothing).