Add feature to disable code upgrades #1906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## actor-upgrades #1906 +/- ##
==================================================
- Coverage 75.91% 75.61% -0.30%
==================================================
Files 153 153
Lines 15220 15146 -74
==================================================
- Hits 11554 11453 -101
- Misses 3666 3693 +27
|
fridrik01
force-pushed
the
feature-flag
branch
from
7fd7df8 to
3b2accf
Compare
fridrik01
force-pushed
the
actor-upgrades
branch
from
dfc4d61 to
0f65803
Compare
Stebalien
added a commit
that referenced
this pull request
Oct 26, 2023
This is a minimal version of #1906 that still compiles the relevent code, just disables it at runtime.
|
I've implemented a minimal version of this in the main PR that just disables the syscall, but still compiles the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding feature flag to have the code upgrade syscall disabled until we officially release it