amt: support start_at that is out of range in the first place
#1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiqiangxu
force-pushed
the
opt_for_each_while_ranged
branch
from
4743288 to
da54ece
Compare
zhiqiangxu
force-pushed
the
opt_for_each_while_ranged
branch
from
da54ece to
e7d1f27
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1901 +/- ##
==========================================
- Coverage 75.73% 75.73% -0.01%
==========================================
Files 152 152
Lines 15078 15084 +6
==========================================
+ Hits 11420 11424 +4
- Misses 3658 3660 +2
|
Stebalien
approved these changes
Sep 28, 2023
|
(I'll merge this now so I can cut a bug-fix release for you) |
|
Nvm. I added a test in #1902. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is found here, instead of panic, we can just return.
This is useful when
start_atis estimated which may be out of range.