Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FIP-0079 with Backwards Compatibility #2001

Closed
rjan90 opened this issue Apr 19, 2024 · 4 comments · Fixed by #2003
Closed

Implement FIP-0079 with Backwards Compatibility #2001

rjan90 opened this issue Apr 19, 2024 · 4 comments · Fixed by #2003
Milestone

Comments

@rjan90
Copy link
Contributor

rjan90 commented Apr 19, 2024

Description

FIP-0079, which has been accepted, introduces a syscall for BLS aggregate signatures. It has a PR open in #1914, but it has not been merged due to concerns about requiring a major FVM version update.

After some discussion we have leaned towards merging this feature under a feature flag to avoid the need of a major version update. This approach would allow the inclusion of the FIP in the upcoming network upgrade without waiting for other significant changes that necessitate a new FVM version.

Task

The current PR is outdated and has a lot of conflicts. We need to created a new branch and copy the PR changes in, make it backwards compatible and add it behind a feature flag.

References

@rjan90 rjan90 added this to the NV23 milestone Apr 19, 2024
@rjan90 rjan90 added this to FilOz Apr 19, 2024
@rjan90 rjan90 moved this to 📌 Triage in FilOz Apr 19, 2024
@Stebalien
Copy link
Member

Basically:

  1. We can make breaking changes to the SDK, as long as we bump the minor version.
  2. We can't remove the current verify_signature syscall.
  3. We can add and use the new verify_bls_aggregate syscall.

So, TODO: Bring back the verify_signature syscall behind an enabled-by-default feature. E.g. IPC can disable it.

@rvagg
Copy link
Member

rvagg commented Apr 19, 2024

👍 it's good not to break things if we don't really need to, especially if it means shipping features that users are asking for 🚢

@rvagg
Copy link
Member

rvagg commented May 6, 2024

This requires an update to FIP-0079 to remove the references to verify_signature, correct?

@Stebalien
Copy link
Member

This requires an update to FIP-0079 to remove the references to verify_signature, correct?

IMO, no. From the perspective of the network, verify_signature will go away. Technically the ref-fvm will expose it as an available syscall, but the builtin actors won't use it (and user deployed actors aren't possible).

@rjan90 rjan90 moved this to 🎉 Done in FilOz May 14, 2024
@rjan90 rjan90 moved this from 🎉 Done to ☑️Done (Archive) in FilOz Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging a pull request may close this issue.

3 participants