[M4] combined updates after review

.env.example

@@ -1 +1,17 @@
-DEPLOYER_PK=""
+# Name of the Docker image used by Developer Env. (./lib-dev/dev-env/)
+FIL_SOL_DOCKER_IMG="fil-sol-dev-env:latest-amd64"
+
+# Private key for the "master" (F4-type) account on Calibration network
+#   - this account is used to fund further all necessary accounts (deployers/actors/...)
+#   - faucet: https://faucet.calibnet.chainsafe-fil.io/send
+ETH_PK=""
+
+# Generated dummy F3-type account on Calibration network using Lotus CLI
+#   - IMPORTANT: do not add real funds !!!
+#   - note: 
+#       - actor IDs don't have to be same on different networks
+#         while the F3_ADDR, F3_PK would remain still the same
+#       - F3_ID is the actor id on the Calibration network
+F3_ADDR="t3wybme2dab6l3h4zuuzxxteztmtq7jyh6qgrko3urkvhjfqdr33vsus4x5s2ccpuhhc5xscpx3bcpufsf6vzq"
+F3_PK="7b2254797065223a22626c73222c22507269766174654b6579223a22484651356a783635315a2f5470734332763846373148746f52706459684e52316b2f577135793968316a673d227d"
+F3_ID="112484"

.gitignore

@@ -19,4 +19,8 @@ yarn.lock
 typechain-types
 
 .openzeppelin/
-.env
+.env
+.vscode
+
+lib-dev/dev-env/.internal
+.wip

.gitmodules

@@ -9,4 +9,4 @@
 	url = https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable
 [submodule "lib/forge-std"]
 	path = lib/forge-std
-	url = https://github.com/foundry-rs/forge-std
+	url = https://github.com/foundry-rs/forge-std

Makefile

@@ -1,4 +1,6 @@
 
+hh_localnet_setup_lock := "localnet-setup-running.lock"
+
 ################ BUILD ################
 solc := "./bin/solc"
 
@@ -131,6 +133,26 @@ test_deserialize: build
 test_address: build
 	cd testing && cargo test address -- --nocapture
 
+################ TESTS HARDHAT ################
+
+start_localnet:
+	./lib-dev/dev-env/1_clean-start-localnet.sh
+
+restart_localnet:
+	./lib-dev/dev-env/2_restart-localnet.sh
+
+simple_start_localnet:
+	./lib-dev/dev-env/3_clean-simple-start.sh
+
+kill_localnet:
+	./lib-dev/dev-env/4_kill-lotus-ps.sh
+
+test_hh_localnet:
+	./lib-dev/dev-env/5_test-run-localnet.sh
+
+test_hh_calibnet:
+	export HH_NETWORK=calibnet && npx hardhat test --bail
+
 ################ TESTS SECURITY ################
 
 security_account_api:
@@ -205,3 +227,5 @@ install-opencl:
 	sudo apt-get update
 	sudo apt-get install ocl-icd-opencl-dev
 
+deps_install: install_solc_linux
+	yarn install

contracts/v0.8/DataCapAPI.sol

@@ -75,8 +75,7 @@ library DataCapAPI {
             return (0, result.deserializeBytesBigInt());
         }
 
-        CommonTypes.BigInt memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.BigInt({val: hex"00", neg: false}));
     }
 
     /// @notice Return the DataCap token balance for the wallet address.
@@ -92,8 +91,7 @@ library DataCapAPI {
             return (0, result.deserializeBytesBigInt());
         }
 
-        CommonTypes.BigInt memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.BigInt({val: hex"00", neg: false}));
     }
 
     /// @notice Return the allowance between owner and operator address.
@@ -109,8 +107,7 @@ library DataCapAPI {
             return (0, result.deserializeBytesBigInt());
         }
 
-        CommonTypes.BigInt memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.BigInt({val: hex"00", neg: false}));
     }
 
     /// @notice Transfers data cap tokens to an address.
@@ -178,8 +175,7 @@ library DataCapAPI {
             return (0, result.deserializeBytesBigInt());
         }
 
-        CommonTypes.BigInt memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.BigInt({val: hex"00", neg: false}));
     }
 
     /// @notice Decrease the DataCap token allowance that an operator controls of the owner's balance by the requested amount.
@@ -202,8 +198,7 @@ library DataCapAPI {
             return (0, result.deserializeBytesBigInt());
         }
 
-        CommonTypes.BigInt memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.BigInt({val: hex"00", neg: false}));
     }
 
     /// @notice Revoke the DataCap token allowance from the operator and set the operator's allowance in behave of owner/caller address to 0.
@@ -226,8 +221,7 @@ library DataCapAPI {
             return (0, result.deserializeBytesBigInt());
         }
 
-        CommonTypes.BigInt memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.BigInt({val: hex"00", neg: false}));
     }
 
     /// @notice Burn an amount of DataCap token from the owner/caller address, decreasing total token supply.
@@ -243,8 +237,7 @@ library DataCapAPI {
             return (0, result.deserializeArrayBigInt());
         }
 
-        CommonTypes.BigInt memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.BigInt({val: hex"00", neg: false}));
     }
 
     /// @notice Burn an amount of DataCap token from the specified address (owner address), decrease the allowance of operator/caller, and decrease total token supply.
@@ -260,7 +253,9 @@ library DataCapAPI {
             return (0, result.deserializeBurnFromReturn());
         }
 
-        DataCapTypes.BurnFromReturn memory empty_res;
-        return (exit_code, empty_res);
+        return (
+            exit_code,
+            DataCapTypes.BurnFromReturn({balance: CommonTypes.BigInt({val: hex"00", neg: false}), allowance: CommonTypes.BigInt({val: hex"00", neg: false})})
+        );
     }
 }

contracts/v0.8/MarketAPI.sol

@@ -79,8 +79,7 @@ library MarketAPI {
             return (0, result.deserializeBytesBigInt());
         }
 
-        CommonTypes.BigInt memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.BigInt({val: hex"00", neg: false}));
     }
 
     /// @notice Return the escrow balance and locked amount for an address.
@@ -96,8 +95,10 @@ library MarketAPI {
             return (0, result.deserializeGetBalanceReturn());
         }
 
-        MarketTypes.GetBalanceReturn memory empty_res;
-        return (exit_code, empty_res);
+        return (
+            exit_code,
+            MarketTypes.GetBalanceReturn({balance: CommonTypes.BigInt({val: hex"00", neg: false}), locked: CommonTypes.BigInt({val: hex"00", neg: false})})
+        );
     }
 
     /// @notice This will be available after the deal is published (whether or not is is activated) and up until some undefined period after it is terminated.
@@ -118,8 +119,7 @@ library MarketAPI {
             return (0, result.deserializeGetDealDataCommitmentReturn());
         }
 
-        MarketTypes.GetDealDataCommitmentReturn memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, MarketTypes.GetDealDataCommitmentReturn({data: hex"", size: 0}));
     }
 
     /// @notice Returns the client for the specified deal
@@ -135,8 +135,7 @@ library MarketAPI {
             return (0, result.deserializeUint64());
         }
 
-        uint64 empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, uint64(0));
     }
 
     /// @notice Returns the provider for a specified deal
@@ -157,8 +156,7 @@ library MarketAPI {
             return (0, result.deserializeUint64());
         }
 
-        uint64 empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, uint64(0));
     }
 
     /// @notice Returns the label of a storage deal
@@ -174,8 +172,7 @@ library MarketAPI {
             return (0, result.deserializeDealLabel());
         }
 
-        CommonTypes.DealLabel memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.DealLabel({data: hex"", isString: false}));
     }
 
     /// @notice Returns the start epoch and duration(in epochs) of a deal proposal.
@@ -191,8 +188,7 @@ library MarketAPI {
             return (0, result.deserializeGetDealTermReturn());
         }
 
-        MarketTypes.GetDealTermReturn memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, MarketTypes.GetDealTermReturn({start: CommonTypes.ChainEpoch.wrap(0), duration: CommonTypes.ChainEpoch.wrap(0)}));
     }
 
     /// @notice Returns the total price that will be paid from the client to the provider for this deal.
@@ -213,8 +209,7 @@ library MarketAPI {
             return (0, result.deserializeBytesBigInt());
         }
 
-        CommonTypes.BigInt memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.BigInt({val: hex"00", neg: false}));
     }
 
     /// @notice get the client collateral requirement for a deal
@@ -235,8 +230,7 @@ library MarketAPI {
             return (0, result.deserializeBytesBigInt());
         }
 
-        CommonTypes.BigInt memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.BigInt({val: hex"00", neg: false}));
     }
 
     /// @notice Returns the provider's collateral requirement for a deal
@@ -257,8 +251,7 @@ library MarketAPI {
             return (0, result.deserializeBytesBigInt());
         }
 
-        CommonTypes.BigInt memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.BigInt({val: hex"00", neg: false}));
     }
 
     /// @notice Returns the verified flag for a deal
@@ -280,8 +273,7 @@ library MarketAPI {
             return (0, result.deserializeBool());
         }
 
-        bool empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, false);
     }
 
     /// @notice Fetches activation state for a deal.
@@ -301,8 +293,7 @@ library MarketAPI {
             return (0, result.deserializeGetDealActivationReturn());
         }
 
-        MarketTypes.GetDealActivationReturn memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, MarketTypes.GetDealActivationReturn({activated: CommonTypes.ChainEpoch.wrap(0), terminated: CommonTypes.ChainEpoch.wrap(0)}));
     }
 
     /// @notice Publish a new set of storage deals (not yet included in a sector).

contracts/v0.8/MinerAPI.sol

@@ -50,8 +50,7 @@ library MinerAPI {
             return (0, result.deserializeGetOwnerReturn());
         }
 
-        MinerTypes.GetOwnerReturn memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, MinerTypes.GetOwnerReturn({owner: CommonTypes.FilAddress({data: hex""}), proposed: CommonTypes.FilAddress({data: hex""})}));
     }
 
     /// @notice Proposes or confirms a change of owner address.
@@ -96,8 +95,7 @@ library MinerAPI {
             return (0, result.deserializeBool());
         }
 
-        bool empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, false);
     }
 
     /// @dev For more information about sector sizes, please refer to https://spec.filecoin.io/systems/filecoin_mining/sector/#section-systems.filecoin_mining.sector
@@ -113,8 +111,7 @@ library MinerAPI {
             return (0, result.deserializeUint64());
         }
 
-        uint64 empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, uint64(0));
     }
 
     /// @notice This is calculated as actor balance - (vesting funds + pre-commit deposit + initial pledge requirement + fee debt)
@@ -136,8 +133,7 @@ library MinerAPI {
             return (0, result.deserializeBytesBigInt());
         }
 
-        CommonTypes.BigInt memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.BigInt({val: hex"00", neg: false}));
     }
 
     /// @notice Returns specified miner's vesting funds
@@ -150,8 +146,7 @@ library MinerAPI {
         if (exit_code == 0) {
             return (0, result.deserializeGetVestingFundsReturn());
         }
-        MinerTypes.VestingFunds[] memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, new MinerTypes.VestingFunds[](0));
     }
 
     /// @notice Proposes or confirms a change of beneficiary address.
@@ -298,8 +293,7 @@ library MinerAPI {
             return (0, result.deserializeArrayFilAddress());
         }
 
-        CommonTypes.FilAddress memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.FilAddress({data: hex""}));
     }
 
     /// @notice Returns miner's multiaddresses
@@ -314,8 +308,7 @@ library MinerAPI {
             return (0, result.deserializeGetMultiaddrsReturn());
         }
 
-        CommonTypes.FilAddress[] memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, new CommonTypes.FilAddress[](0));
     }
 
     /// @notice Withdraws balance for a specified miner
@@ -339,7 +332,6 @@ library MinerAPI {
             return (0, result.deserializeBytesBigInt());
         }
 
-        CommonTypes.BigInt memory empty_res;
-        return (exit_code, empty_res);
+        return (exit_code, CommonTypes.BigInt({val: hex"00", neg: false}));
     }
 }