Make sure we can reach the user's requested FVM concurrency #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously used the FVM's `ThreadedExecutor` to execute messages on separate threads because the FVM requires 64MiB of stack space. 1. The FVM v3 supported for 8 concurrent threads. 2. The FVM v4 supports up to the number of CPU threads available. Unfortunately, neither version was influenced by the `LOTUS_FVM_CONCURRENCY` environment variable. This patch fixes this by: 1. Moving the thread-pool to the FFI itself (sharing it between FVM versions). 2. Setting the thread-pool size equal to `LOTUS_FVM_CONCURRENCY`. It also defaults `LOTUS_FVM_CONCURRENCY` to the number of available CPU threads instead of the previous 4. NOTE: I've also tried increasing the stack size instead of using threads, but Go _does not_ like it when other foreign mess with the stack size of _its_ threads (but it has no problem if we create our own threads). fixes filecoin-project/lotus#11817
Stebalien
force-pushed
the
steb/actual-concurrency
branch
from
255a0a9 to
c6296ec
Compare
Stebalien
added a commit
to filecoin-project/lotus
that referenced
this pull request
Apr 6, 2024
|
@vbaranov (sorry, I'm not sure who I should be pinging). When trying to give the FVM "saner defaults" with respect to concurrency to make indexing the Filecoin chain less painful, I came across another issue. For epochs 2683348 to 3469380 (FVMv3), the FVM will be limited to at most 8 parallel executions even if you raise This patch:
I've created a lotus branch if you want to test it out: https://github.com/filecoin-project/lotus/tree/steb/actual-concurrency |
rvagg
reviewed
Apr 10, 2024
Co-authored-by: Rod Vagg <[email protected]>
rvagg
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used the FVM's
ThreadedExecutorto execute messages on separate threads because the FVM requires 64MiB of stack space.Unfortunately, neither version was influenced by the
LOTUS_FVM_CONCURRENCYenvironment variable.This patch fixes this by:
LOTUS_FVM_CONCURRENCY.It also defaults
LOTUS_FVM_CONCURRENCYto the number of available CPU threads instead of the previous 4.NOTE: I've also tried increasing the stack size instead of using threads, but Go does not like it when other foreign mess with the stack size of its threads (but it has no problem if we create our own threads).
fixes filecoin-project/lotus#11817
replaces #448