-
Notifications
You must be signed in to change notification settings - Fork 32
chore(pdp): M3 Calibnet contract addresses and ABIs #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pdpv0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there ABI change? If yes, then ABIs and Json need upgrading. I think createDataSet has been changed as well. Or is that out of scope for this PR?
Yeah, the ABIs are in the assets of each release now. I.e:
Will look at upgrading the ABIs and JSON here in Curio |
Jst jotting down the step-by-step things I did for updating contract ABIs in Curio, so that I can feed that into Upgrade Dependencies document, so that this will be simpler to follow if there is new contracts published (and potentially automate) in the future: Installed abigen: Exported path: Download ABIs directly from PDP release:
Regenrate the go-binding:
@wjmelements I see that we have checked in some .json files here https://github.com/filecoin-project/curio/blob/main/pdp/contract/IPDPProvingSchedule.json, are those actually needed with the above approach? |
I tried to point Claude to sort out the breaking changes in a PR ontop of this branch here: #685. But someone else should feel free to take that over, in case Claude is really out of touch here. |
The json files seem redundant and can be removed. I don't think anyone is using them except for their abi. If we're getting the abi from somewhere else we can remove them. But you should also remove their makefile recipe, replacing it with a comment on where they come from. |
Converting to draft until have contract address from FilOzone/filecoin-services#268 |
Okay, contracts and ABIs update to the PDP v2.2.1 release which added the Can confirm that I see the Steps taken: Exported path: Download ABIs directly from PDP release:
Regenrate the go-binding: |
chore(pdp): M3 Calibnet contract addresses
chore: update ABIs and ABIgen with make
fix: remove redundnat .json files and add comment on where these ABIs can be found
chore: update to PDP v2.2.1 address and FWSS v0.3.0 proxy
e188e1f
to
ec0db84
Compare
chore: add link to FWSS v0.1.0 proxy address
Closes: #679