Skip to content

Conversation

rjan90
Copy link
Collaborator

@rjan90 rjan90 commented Oct 7, 2025

Closes: #679

@rjan90 rjan90 requested a review from a team as a code owner October 7, 2025 10:48
@rjan90 rjan90 self-assigned this Oct 7, 2025
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there ABI change? If yes, then ABIs and Json need upgrading. I think createDataSet has been changed as well. Or is that out of scope for this PR?

@rjan90
Copy link
Collaborator Author

rjan90 commented Oct 7, 2025

Is there ABI change?

Yeah, the ABIs are in the assets of each release now. I.e:

Will look at upgrading the ABIs and JSON here in Curio

@rjan90 rjan90 mentioned this pull request Oct 7, 2025
3 tasks
@rjan90 rjan90 changed the title chore(pdp): M3 Calibnet contract addresses chore(pdp): M3 Calibnet contract addresses and ABIs Oct 7, 2025
@rjan90
Copy link
Collaborator Author

rjan90 commented Oct 7, 2025

Jst jotting down the step-by-step things I did for updating contract ABIs in Curio, so that I can feed that into Upgrade Dependencies document, so that this will be simpler to follow if there is new contracts published (and potentially automate) in the future:

Installed abigen:
go install github.com/ethereum/go-ethereum/cmd/abigen@latest

Exported path:
export PATH=$PATH:$HOME/go/bin && which abigen

Download ABIs directly from PDP release:

curl -L https://github.com/FilOzone/pdp/releases/download/v2.2.0/PDPVerifier.abi.json \
     -o pdp/contract/PDPVerifier.abi
curl -L https://github.com/FilOzone/pdp/releases/download/v2.2.0/IPDPProvingSchedule.abi.json \
     -o pdp/contract/IPDPProvingSchedule.abi

Regenrate the go-binding:

  • make pdp/contract/PDPVerifier.go
  • make pdp/contract/IPDPProvingSchedule.go

@wjmelements I see that we have checked in some .json files here https://github.com/filecoin-project/curio/blob/main/pdp/contract/IPDPProvingSchedule.json, are those actually needed with the above approach?

@rjan90
Copy link
Collaborator Author

rjan90 commented Oct 7, 2025

I tried to point Claude to sort out the breaking changes in a PR ontop of this branch here: #685.

But someone else should feel free to take that over, in case Claude is really out of touch here.

@rjan90 rjan90 requested a review from wjmelements October 7, 2025 18:40
@wjmelements
Copy link
Collaborator

@wjmelements I see that we have checked in some .json files here https://github.com/filecoin-project/curio/blob/main/pdp/contract/IPDPProvingSchedule.json, are those actually needed with the above approach?

The json files seem redundant and can be removed. I don't think anyone is using them except for their abi. If we're getting the abi from somewhere else we can remove them. But you should also remove their makefile recipe, replacing it with a comment on where they come from.

@BigLep
Copy link
Member

BigLep commented Oct 8, 2025

Converting to draft until have contract address from FilOzone/filecoin-services#268

@BigLep BigLep marked this pull request as draft October 8, 2025 21:57
@rjan90
Copy link
Collaborator Author

rjan90 commented Oct 8, 2025

Okay, contracts and ABIs update to the PDP v2.2.1 release which added the createDataSet function back again in: e188e1f.

Can confirm that I see the createDataSet in added in the ABI: e188e1f#diff-87918e048ec91ee7cbd1911449e0fd45b3f1cfd09fe0bbd15562f106f7090583.


Steps taken:

Exported path:
export PATH=$PATH:$HOME/go/bin && which abigen

Download ABIs directly from PDP release:

curl -L https://github.com/FilOzone/pdp/releases/download/v2.2.0/PDPVerifier.abi.json \
     -o pdp/contract/PDPVerifier.abi
curl -L https://github.com/FilOzone/pdp/releases/download/v2.2.0/IPDPProvingSchedule.abi.json \
     -o pdp/contract/IPDPProvingSchedule.abi

Regenrate the go-binding:
make pdp/contract/PDPVerifier.go
make pdp/contract/IPDPProvingSchedule.go

@rjan90 rjan90 marked this pull request as ready for review October 8, 2025 22:24
rjan90 added 4 commits October 9, 2025 09:30
chore(pdp): M3 Calibnet contract addresses
chore: update ABIs and ABIgen with make
fix: remove redundnat .json files and add comment on where these ABIs can be found
chore: update to PDP v2.2.1 address and FWSS v0.3.0 proxy
@rjan90 rjan90 force-pushed the phi/update-contract-calibnet branch from e188e1f to ec0db84 Compare October 9, 2025 07:31
chore: add link to FWSS v0.1.0 proxy address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants