Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sector selection in snap ingester #137

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

magik6k
Copy link
Collaborator

@magik6k magik6k commented Aug 9, 2024

Should address all concerns from #104

Definitely fixes sector selection logic.

@magik6k magik6k requested review from LexLuthr and snadrus August 9, 2024 14:45
@magik6k magik6k force-pushed the fix/snap-expired-sumbit branch from fbefb2e to 23a3391 Compare August 9, 2024 14:45
@magik6k
Copy link
Collaborator Author

magik6k commented Aug 9, 2024

The last commit implements the fix also done in filecoin-project/lotus#12342; We'll also need that for PoRep side, opened an issue for it - #138

Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We missed an important point. If a sector is extended using sptool then our DB would not know about it. Thus our sector selection is never going to be correct. We need a IAmBored job which updated the sector expiration every few hours in the DB. Only for sector_meta table.
Or we can check expiration of each sector online and then do the selection.
IAmBored seems a cleaner approach.

market/deal_ingest_snap.go Show resolved Hide resolved
market/deal_ingest_snap.go Show resolved Hide resolved
market/deal_ingest_snap.go Show resolved Hide resolved
tasks/seal/task_submit_commit.go Show resolved Hide resolved
@magik6k
Copy link
Collaborator Author

magik6k commented Aug 9, 2024

We need a IAmBored job which updated the sector expiration every few hours in the DB

We have that: https://github.com/filecoin-project/curio/blob/main/tasks/metadata/task_sector_expirations.go

@LexLuthr
Copy link
Contributor

LexLuthr commented Aug 9, 2024

We need a IAmBored job which updated the sector expiration every few hours in the DB

We have that: https://github.com/filecoin-project/curio/blob/main/tasks/metadata/task_sector_expirations.go

I don't know how I missed that. 🤦

Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

90 days grace period is a f05 market deal thing and not part of power/miner actor.

@magik6k magik6k merged commit 0ce2342 into main Aug 9, 2024
7 checks passed
@magik6k magik6k deleted the fix/snap-expired-sumbit branch August 9, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants