IPLD refactor #108
Merged
IPLD refactor #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergkaprovich
force-pushed
the
feature/ipld-refactor
branch
2 times, most recently
from
6fddd68 to
507af8b
Compare
masterjedy
requested changes
Feb 21, 2020
igor-egorov
requested changes
Feb 25, 2020
There was a problem hiding this comment.
Please check #114 before merging. Otherwise, it may introduce a lot of inconsistency in targets' naming, way of protobuf compiling, etc.
masterjedy
requested changes
Feb 25, 2020
masterjedy
approved these changes
Feb 25, 2020
sergkaprovich
force-pushed
the
feature/ipld-refactor
branch
from
d20dfc0 to
ffb4729
Compare
sergkaprovich
force-pushed
the
feature/ipld-refactor
branch
from
ffb4729 to
942d3f7
Compare
igor-egorov
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attention
Major part of the files changed was already reviewed previously by Pull #77 - here is just moving parts of this files to another namespaces/locations
New files needed to review:
Description of the Change
storage::ipfs::Nodemoved to `storage::ipld::IPLDNode"storage::ipfs::Linkmoved to `storage::ipld::IPLDLink"Benefits
Standalone implementation of the IPLD block, which can be re-used in future (in plans: TxMeta structures, IPLD selectors and so on...)
Splitting IPFS and IPLD notions according data structures
Possible Drawbacks
None