-
Notifications
You must be signed in to change notification settings - Fork 4
Add KV cache for D1 index. Closes #306 #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
juliangruber
wants to merge
56
commits into
main
Choose a base branch
from
add/index-cache
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 13 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
fbbe19e
add KV cache for C1 index
juliangruber de444fb
add passing test
juliangruber 0d3f60a
add passing test
juliangruber 69291bf
add missing wrangler config
juliangruber a093922
add test, fix implementation
juliangruber e8608ef
fix order
juliangruber 8abd8ef
add passing test
juliangruber c504896
add passing test
juliangruber 8f879bf
fix indentation
juliangruber 6b5f822
fix unrelated test
juliangruber 624b184
add passing test
juliangruber b66e758
Merge branch 'main' into add/index-cache
juliangruber 5f18618
update KV ids
juliangruber 19cb854
Update piece-retriever/bin/piece-retriever.js
juliangruber ed6c067
fix lint
juliangruber 4acf720
Merge branch 'main' into add/index-cache
juliangruber 7101bb0
fix lint & types
juliangruber fe5d246
refactor `sqlPlaceholders`
juliangruber d149614
cache bad bits separately (wip)
juliangruber 7158b9d
Merge branch 'main' into add/index-cache
juliangruber f4115c4
implement strategy
juliangruber 738399e
fmt
juliangruber fd35178
fix type errors
juliangruber 93b0acc
fix test
juliangruber d6b095f
clean up bad bits tables
juliangruber 117f878
fix test
juliangruber 982b25a
fix test
juliangruber d4d1fec
move bad bits to kv
juliangruber d850cfa
chore: fix TypeScript errors
bajtos 9107a5d
fix: remove apply-migrations.js reference from vitest.config.js
pyropy 56e807d
Merge branch 'update/move-bad-bits-to-kv' into add/index-cache
juliangruber 720fb95
move `getAllBadBitHashes`
juliangruber 41ecdb9
only write etag if was capped
juliangruber bc780ed
give bad bits its own kv namespace
juliangruber c158b88
refactor `persistUpdates()`
juliangruber 1a72ebe
allow `latest-hashes:*` to shrink
juliangruber 112e8dd
Apply suggestion from @pyropy
juliangruber a818ad3
Apply suggestion from @pyropy
juliangruber eb3c03f
Apply suggestion from @pyropy
juliangruber 174d6bd
refactor using `Set#difference()`
juliangruber 97332cf
fmt
juliangruber 30cd11b
Merge branch 'main' into update/move-bad-bits-to-kv
juliangruber 17de33a
Merge branch 'update/move-bad-bits-to-kv' into add/index-cache
juliangruber 3b2a846
rename `KV` to `INDEX_CACHE_KV`
juliangruber 2270be5
refactor
juliangruber 6e1e6cd
test: reliably clear all kv data
juliangruber d786f26
fix `wasCapped`
juliangruber 0b891ef
refactor
juliangruber 8f694c5
Update bad-bits/lib/store.js
juliangruber 7d84c55
use r2 for `latest-hashes`
juliangruber e141fbe
Merge branch 'update/move-bad-bits-to-kv' of https://github.com/filbe…
juliangruber 14c9fbc
Merge branch 'main' into update/move-bad-bits-to-kv
juliangruber 9aed565
Merge branch 'update/move-bad-bits-to-kv' into add/index-cache
juliangruber 248a038
fix test
juliangruber 48597ec
Merge branch 'main' into add/index-cache
juliangruber 041f09f
rebuild
juliangruber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.