Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Handling duplicates #9519

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Clarify Handling duplicates #9519

merged 2 commits into from
Nov 8, 2023

Conversation

maltbymike
Copy link
Contributor

@maltbymike maltbymike commented Nov 8, 2023 •
edited
Loading

In order to correctly attach a duplicate record the allowDuplicate() method must be added to the table

  • Changes have been thoroughly tested to not break existing functionality.
  • New functionality has been documented or existing documentation has been updated to reflect changes.
  • Visual changes are explained in the PR description using a screenshot/recording of before and after.

@maltbymike
Clarify Handling duplicates
ea64d66 
In order to correctly attach a duplicate record the allowDuplicate() method must be added to the table
@danharrin danharrin added the documentation Improvements or additions to documentation label Nov 8, 2023
@danharrin danharrin added this to the v3 milestone Nov 8, 2023
@danharrin
Copy link
Member

$allowsDuplicates doesnt actually do anything, this was out of date documentation from v2

@danharrin danharrin merged commit 029eb1b into filamentphp:3.x Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danharrin danharrin danharrin left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
Roadmap
Status: Done
Milestone
v3
Development

Successfully merging this pull request may close these issues.
2 participants
@maltbymike @danharrin