Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of indentation during file creation. #9496

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Correction of indentation during file creation. #9496

merged 2 commits into from
Nov 8, 2023

Conversation

bzy107
Copy link
Contributor

@bzy107 bzy107 commented Nov 6, 2023

  • Changes have been thoroughly tested to not break existing functionality.
  • New functionality has been documented or existing documentation has been updated to reflect changes.
  • Visual changes are explained in the PR description using a screenshot/recording of before and after.

When creating resource files, the indentation is not consistent, and manual corrections are required each time.
I have made a fix to address this issue.

I have conducted the verification as follows.

php artisan make:filament-resource Customer
before after
スクリーンショット 2023-11-07 2 10 51 スクリーンショット 2023-11-07 2 12 29
php artisan make:filament-resource Customer --soft-deletes
before after
スクリーンショット 2023-11-07 2 14 46 スクリーンショット 2023-11-07 2 15 56

Please confirm.

@zepfietje
Copy link
Member

Do we need this in any other make commands too?

@zepfietje zepfietje added this to the v3 milestone Nov 7, 2023
@zepfietje zepfietje added the bug Something isn't working label Nov 7, 2023
@bzy107
Copy link
Contributor Author

bzy107 commented Nov 7, 2023

No, I also tried the following commands, those are not a problem.

make:filament-page
make:filament-panel
make:filament-relation-manager
make:filament-widget

@danharrin danharrin merged commit 539206a into filamentphp:3.x Nov 8, 2023
4 checks passed
@danharrin
Copy link
Member

It's because all commands use this trait for indentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants