Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Inter font family to file upload #9445

Merged
merged 5 commits into from
Nov 4, 2023

Conversation

urufudev
Copy link
Contributor

@urufudev urufudev commented Nov 3, 2023

The Inter font was set in the file upload field because it currently displays Segoe UI. This takes advantage of the fact that tailwindcss already has Inter font configured and is being used.

Before:
Captura de pantalla 2023-11-03 104558

After:
Captura de pantalla 2023-11-03 104937

  • Changes have been thoroughly tested to not break existing functionality.
  • New functionality has been documented or existing documentation has been updated to reflect changes.
  • Visual changes are explained in the PR description using a screenshot/recording of before and after.

@zepfietje zepfietje added this to the v3 milestone Nov 4, 2023
@zepfietje zepfietje added the bug Something isn't working label Nov 4, 2023
@zepfietje
Copy link
Member

zepfietje commented Nov 4, 2023

Thanks for spotting this, @urufudev!
Could you rework this PR to use the font family CSS variable that Filament uses internally?

Please mark as ready for review when done.

@zepfietje zepfietje marked this pull request as draft November 4, 2023 11:10
@urufudev urufudev marked this pull request as ready for review November 4, 2023 17:15
@danharrin
Copy link
Member

Please recompile the assets with npm run build and test it

@urufudev
Copy link
Contributor Author

urufudev commented Nov 4, 2023

Please recompile the assets with npm run build and test it

I was able to test it with 'npm run build,' and it was working correctly. Should I also upload the changes to 'packages/forms/dist/index.css'

@danharrin
Copy link
Member

Yes, please upload the compiled files

@danharrin danharrin merged commit fc354f2 into filamentphp:3.x Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants