Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: key-value form component initial rows/state synchronization #15346

Merged

Conversation

borjajimnz
Copy link
Contributor

Description

As described in #13416, there was an issue with the frontend state not reflecting the actual state. This occurred because, during the update process, shouldUpdateRows was initially set to false, preventing the update.

After modifying this behavior, the issue has been resolved, as demonstrated in the following example.

Visual changes

https://youtu.be/lKEOCOkdDos

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@borjajimnz borjajimnz changed the title Hotfix/update key value front state Fix: key-value form component initial rows/state synchronization Jan 14, 2025
@danharrin danharrin added the bug Something isn't working label Jan 22, 2025
@danharrin danharrin added this to the v3 milestone Jan 22, 2025
@danharrin danharrin merged commit 6c76ce4 into filamentphp:3.x Jan 22, 2025
11 checks passed
@danharrin
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants