Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent stacked, editable table columns to trigger wrapping a.href #15340

Merged
merged 8 commits into from
Jan 22, 2025

Conversation

tanthammar
Copy link
Contributor

Description

Fixes: If you have your table columns stacked, and click on an editable column the outer a.href will be triggered and the record will open instead of editing the value of the column.

Visual changes

None

Functional changes

  • The editable column becomes editable instead of only triggering the redirect.

  • Code style has been fixed by running the composer cs command.
    No, tried multiple times, still spaces are added that were not there before, sorry...

  • Changes have been tested to not break existing functionality.
    yes,

  • Checkbox: click.stop.prevent was needed on the wrapping div. Else a.href is triggered if Alpine.isLoading is true

  • Text input, Toogle and Select columns was enough with adding .prevent on the existing x-on:click.stop

-[X] Documentation is up-to-date.

@danharrin danharrin added the bug Something isn't working label Jan 14, 2025
@danharrin danharrin added this to the v3 milestone Jan 14, 2025
@danharrin danharrin merged commit b921e4c into filamentphp:3.x Jan 22, 2025
10 checks passed
@danharrin
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants