Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump/league csv remove deprecate #15222

Closed

Conversation

wychoong
Copy link
Contributor

@wychoong wychoong commented Jan 2, 2025

Description

noticed a deprecation notice, applied for v4 instead as not sure if this should be bumped in v3

Visual changes

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin
Copy link
Member

Can you do it for v3 please? Since this is a minor version

@danharrin danharrin added the bug Something isn't working label Jan 2, 2025
@danharrin danharrin added this to the v3 milestone Jan 2, 2025
@wychoong
Copy link
Contributor Author

wychoong commented Jan 2, 2025

Can you do it for v3 please? Since this is a minor version

submitted a new PR for v3. there is a difference in ImportAction implementation, its a trait in v3

@wychoong wychoong closed this Jan 2, 2025
@wychoong wychoong deleted the bump/league-csv-remove-deprecate branch January 2, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants